[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: 8044059: Memory Leak in Elliptic Curve Private Key Generation
From:       Vincent Ryan <vincent.x.ryan () oracle ! com>
Date:       2014-05-28 16:23:49
Message-ID: B75683F2-EF74-4609-AC6B-1CF3DCD5AA0B () oracle ! com
[Download RAW message or body]

It’s difficult to develop a useful test that is cross-platform so let’s skip the \
testcase for this fix.


On 28 May 2014, at 17:21, Jeremy Manson <jeremymanson@google.com> wrote:

> You can defer the change if you need to.  I'm going on vacation from the 6th to the \
> 16th, so there are timing issues around that. 
> At Google, we plug in a different version of malloc that checks to make sure that \
> you've freed everything you've allocated.  It's a bit painful to write this from \
> scratch, but I might be able to hack something together for you (that only runs on \
> Linux), if you want. 
> Jeremy
> 
> 
> On Wed, May 28, 2014 at 8:52 AM, Vincent Ryan <vincent.x.ryan@oracle.com> wrote:
> I’ll begin reviewing your changeset and get back to you.
> Thanks.
> 
> On 28 May 2014, at 16:28, Jeremy Manson <jeremymanson@google.com> wrote:
> 
> > Ah, okay.  Thanks, Iris.  I should already know known that - Martin has explained \
> > it to me before. 
> > Vincent - let me know how you want to proceed.
> > 
> > Jeremy
> > 
> > 
> > On Tue, May 27, 2014 at 10:00 PM, Iris Clark <iris.clark@oracle.com> wrote:
> > Hi, Jeremy.
> > 
> > As an "Author", you can create a changeset but you can't push to the repo until \
> > you're a "Committer".  Additional details about the differences between Author \
> > and Committer may be found here [1,2]. 
> > The diffs to create a changeset are (of course) in your webrev.  Your Sponsor can \
> > use that along with the "hg commit -u jmanson ..." to list you as the changeset \
> > Author.  Alternatively, your Sponsor may want you to just send the output of "hg \
> > export -g" which would preserve information in the changeset header including the \
> > author, commit comment, etc. 
> > Thanks,
> > iris
> > 
> > [1]: http://openjdk.java.net/projects/#project-author
> > [2]: http://openjdk.java.net/projects/#project-committer
> > 
> > -----Original Message-----
> > From: Jeremy Manson [mailto:jeremymanson@google.com]
> > Sent: Tuesday, May 27, 2014 2:19 PM
> > To: Vincent Ryan
> > Cc: OpenJDK; core-libs-dev
> > Subject: Re: RFR: 8044059: Memory Leak in Elliptic Curve Private Key Generation
> > 
> > Thanks, Vincent.  This would be the first change I've made as an author, so I'm \
> > not sure what the process is.  I think I just need someone to do the review, and \
> > then I can check it in? 
> > Jeremy
> > 
> > 
> > On Tue, May 27, 2014 at 1:55 PM, Vincent Ryan <vincent.x.ryan@oracle.com>
> > wrote:
> > 
> > > Thanks Jeremy. I believe you have JDK 9 Author status so can sponsor
> > > your fix if you wish.
> > > 
> > > On 27 May 2014, at 21:09, Jeremy Manson <jeremymanson@google.com> wrote:
> > > 
> > > > Just like the title says - every time you generate a new private
> > > > key, you leak a little memory.  Webrev here:
> > > > 
> > > > http://cr.openjdk.java.net/~jmanson/8044059/webrev/
> > > > 
> > > > This is probably the wrong mailing list for this bug, but I expect
> > > someone
> > > > on this list will point me in the right direction.
> > > > 
> > > > Jeremy
> > > 
> > > 
> > 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]