[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    JDK 8 code review request for 7082231 "Put a @since 1.7 on System.lineSeparator"
From:       eamonn.mcmanus () oracle ! com (Eamonn McManus)
Date:       2011-08-24 7:15:59
Message-ID: 4E54A52F.3030003 () oracle ! com
[Download RAW message or body]

Looks good. But I am thinking that this shows we need a regression test 
that ensures that there are no missing @since tags, given that JDK 7 
went out without this one. I am imagining two doclets, one of which 
creates a file with a list of the signatures of every public element 
(class, method, constructor, or field), and the other of which checks 
that every public element is either listed in the file or has a @since 
tag. So we would have run the first doclet on JDK 6 and then used its 
output with the second doclet to check JDK 7. I'm probably stating the 
obvious.

?amonn


On 24/8/11 12:43 AM, Joe Darcy wrote:
> Hello.
>
> Please review this simple patch to fix 7082231 "Put a @since 1.7 on 
> System.lineSeparator", which will correct an @since tag omitted by the 
> JDK 7 fix for 6900043 "Add method to return line.separator property."
>
> diff --git a/src/share/classes/java/lang/System.java 
> b/src/share/classes/java/lang/System.java
> --- a/src/share/classes/java/lang/System.java
> +++ b/src/share/classes/java/lang/System.java
> @@ -632,6 +632,7 @@
>      *
>      * <p>On UNIX systems, it returns {@code "\n"}; on Microsoft
>      * Windows systems it returns {@code "\r\n"}.
> +     * @since 1.7
>      */
>     public static String lineSeparator() {
>         return lineSeparator;
>
>
> Thanks,
>
> -Joe

[prev in list] [next in list] [prev in thread] [next in thread]