[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Review (Updated) : 4884238 : Constants for Standard Charsets
From:       mark.reinhold () oracle ! com (mark ! reinhold at oracle ! com)
Date:       2011-04-27 3:43:41
Message-ID: 20110427034341.648F35BA () eggemoggin ! niobe ! net
[Download RAW message or body]

(just saw your message; more e-mail delays I suppose)

2011/4/19 17:22 -0700, mike.duigou at oracle.com:
> My sentiment is for StandardCharset.
> 
> I received offlist feedback which would support this. The pattern for
> enum like collections of constants has been to use the singular form;
> java.math.RoundingMode, java.lang.annotation.ElementType,
> javax.lang.model.element.ElementKind, java.lang.management.MemoryType,
> etc.

You're not defining an "enum-like collection of constants"; you're
defining a set of convenient static constant values.  In this way it's
much more similar to java.util.Collections and j.u.Arrays and other
multiply-named classes than it is to singularly-named enum classes.
The only difference is that you're defining static constants rather
than static methods.

> The NIO 2 / JSR 203 classes use the relatively new naming convention of
> "Standard" for platform defined constants.

The uses of "Standard" in JSR 203 are for enums.

> Any strong reason to use the plural form?

See above.

- Mark

[prev in list] [next in list] [prev in thread] [next in thread]