[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: RFR: 8332226: "Invalid package name:" from source launcher [v2]
From:       Christian Stein <cstein () openjdk ! org>
Date:       2024-05-17 9:19:14
Message-ID: lRGb7B_2YrEIEzteOKe0XQrcmhYCXqfPTtGvHab-eyI=.759ae285-d5a1-4d50-8433-43813a3cdc0c () github ! com
[Download RAW message or body]

> Please review this change excluding directory paths with invalid elements when \
> computing the packages of a module in source-launch mode. 
> Note that this inital iteration of the change only fixes the in-memory computation \
> of package names - the behaviour of the associated module reader implementation is \
> untouched for the time being. This introduces a difference in the set of resources \
> being readable at runtime. For example, see the modified test case: the new and \
> invalid `.bar` directory doesn't show up in the contents of the module - but it is \
> reported by the module reader's `list()` method. 
> Note additionally, that above's behaviour is also observed for compiled and \
> exploded modules. Meaning, that with this change being applied, the source mode and \
> compiled mode of the launcher are in line.

Christian Stein has updated the pull request incrementally with one additional commit \
since the last revision:

  Copy `ModulePath`'s exploded directories logic

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19245/files
  - new: https://git.openjdk.org/jdk/pull/19245/files/ba9c8869..d0194523

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19245&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19245&range=00-01

  Stats: 55 lines in 2 files changed: 31 ins; 1 del; 23 mod
  Patch: https://git.openjdk.org/jdk/pull/19245.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19245/head:pull/19245

PR: https://git.openjdk.org/jdk/pull/19245


[prev in list] [next in list] [prev in thread] [next in thread]