[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: RFR: 8297879: javadoc link to preview JEP 1000 has grouping character comma
From:       Vicente Romero <vromero () openjdk ! org>
Date:       2024-03-18 16:28:27
Message-ID: Z6jHQE1QMiG7a6IX3zt3X-3oe9r25rI0CSi0JsnaV6E=.92574e35-a1bd-460b-ad9b-cfd86393a768 () github ! com
[Download RAW message or body]

On Mon, 18 Mar 2024 14:53:44 GMT, Pavel Rappo <prappo@openjdk.org> wrote:

> Please review this simple bugfix to properly construct links to preview JEPs.
> 
> The most straightforward fix I could think of was to pass `String` rather than \
> `int` (`Integer`) to a method, which eventually calls \
> `java.text.MessageFormat.format(String, Object...)`. 
> For the test, I decided to be ~lazy~ practical and piggyback on the existing \
> infrastructure. The alternatives were: 
> 1. slap `noreg-hard` on the JBS bug and skip testing
> 2. create a sophisticated test that dynamically adds a constant into the \
> `PreviewFeature.Feature` enum, annotates some class with `PreviewFeature` with that \
> constant, and finally documents that class with `PreviewFeature` patched into \
> `java.base` 
> While (1) is insufficient, (2) seems overkill in this case.

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18350#pullrequestreview-1943594610


[prev in list] [next in list] [prev in thread] [next in thread]