[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: RFR: 8267317: Remove DeferredTypeCompleter [v2]
From:       Vicente Romero <vromero () openjdk ! java ! net>
Date:       2021-05-24 23:23:10
Message-ID: bzsI76K8koWGH8_cZRuskDApPQIFv8FnI0tpCST5D68=.9fbca5db-ae77-435b-9886-6e2707188d19 () github ! com
[Download RAW message or body]

On Tue, 18 May 2021 13:08:05 GMT, Maurizio Cimadamore <mcimadamore@openjdk.org> \
wrote:

> > This pathc removes DeferredTypeCompleter, which seems like a dubious abstraction. \
> > In its place there is now a `complete` method on `DeferredType` which is \
> > overridden by `ArgumentType`. The only problematic usage is from \
> > `StructuralStuckChecker`, but after inspecting the code I realized that the only \
> > side effect this code expected from calling `DeferredType::check` was to set the \
> > deferred type mode to `SPECULATIVE`, which we can easily do inline.
> 
> Maurizio Cimadamore has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Remove redundant assigment of DeferredType::mode

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4091


[prev in list] [next in list] [prev in thread] [next in thread]