[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: RFR: 8258535: jvm.ClassReader should set the accessor to the corresponding record component
From:       Joel =?UTF-8?B?Qm9yZ2dyw6luLUZyYW5jaw==?= <jfranck () openjdk ! java ! net>
Date:       2021-05-24 12:25:23
Message-ID: grrP_LiVFUpFNa05mIK-6YnCraekDkxLvoA51WqHVoM=.099ba4c7-4496-49ff-8984-1493b88e78ae () github ! com
[Download RAW message or body]

On Sat, 22 May 2021 05:40:46 GMT, Vicente Romero <vromero@openjdk.org> wrote:

> Please review this fix which addresses a bug in the records implementation. The \
> issue is that when a record is read by jvm.ClassReader, the record components are \
> not linked to its corresponding accessor. If users try to look for the accessor \
> using javax.lang.model API, using an annotation processor for example, then they \
> will find that the accessor is null. 
> TIA for the review

Lgtm

-------------

Marked as reviewed by jfranck (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4152


[prev in list] [next in list] [prev in thread] [next in thread]