[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: RFR: 8230827 javac gives inappropriate warning about potentially ambiguous methods
From:       Adam Sotona <adam.sotona () oracle ! com>
Date:       2020-05-28 8:58:38
Message-ID: 6600789C-98E5-4586-8387-356DE631B788 () oracle ! com
[Download RAW message or body]

Thanks for the review.

May I ask you for integration of the patch :) here is changeset version of the \
webrev: http://cr.openjdk.java.net/~asotona/8230827/webrev.01/

Thanks,
Adam

> On 28 May 2020, at 10:45, Jan Lahoda <jan.lahoda@oracle.com> wrote:
> 
> Seems reasonable to me.
> 
> Jan
> 
> On 26. 05. 20 8:08, Adam Sotona wrote:
> > Hi,
> > I would like to ask for review of the patch fixing \
> > com.sun.tools.javac.comp.Comp:checkPotentiallyAmbiguousOverloads. The actual \
> > implementation is too strict and is warning about ambiguous methods even they \
> > differ in following parameters. Plus I've created a test for ambiguous and \
> >                 non-ambiguous cases.
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8230827
> > webrev: http://cr.openjdk.java.net/~asotona/8230827/webrev.00/
> > Mach 5 build with the patch passes all Tier 1 and Tier 2 tests.
> > Several unrelated Tier 3 tests are actually failing.
> > Thanks for the review,
> > Adam


[prev in list] [next in list] [prev in thread] [next in thread]