[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: RFR(XS): 8237601: test/langtools/tools/javac/warnings/MaxDiagsRecompile.java fails after
From:       Mikael Vidstedt <mikael.vidstedt () oracle ! com>
Date:       2020-01-22 1:41:46
Message-ID: E08E5F3B-CC6A-47E7-B2A9-30A61035F454 () oracle ! com
[Download RAW message or body]


Thanks David. Change pushed.

Cheers,
Mikael

> On Jan 21, 2020, at 5:34 PM, David Holmes <david.holmes@oracle.com> wrote:
> 
> Looks good to me - and trivial.
> 
> Thanks,
> David
> 
> > > On Jan 21, 2020, at 3:58 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com> \
> > > wrote:
> > tools/javac/warnings/MaxWarnsRecompile.java needs the same kind of fix. New \
> >                 webrev:
> > full: http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.01/open/webrev/
> > incremental: http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.01.incr/open/webrev/ \
> > <http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.01.incr/open/webrev/> \
> > Cheers, Mikael
> > > On Jan 21, 2020, at 3:58 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com> \
> > > wrote: Please review this small change which fixes the "golden" files used by \
> > > the MaxDiagsRecompile test. JDK-8237589 updated the file header, shifting all \
> > >                 the line numbers by 4.
> > > JBS: https://bugs.openjdk.java.net/browse/JDK-8237601 \
> > >                 <https://bugs.openjdk.java.net/browse/JDK-8237601>
> > > webrev: http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.00/open/webrev/ \
> > > <http://cr.openjdk.java.net/~mikael/webrevs/8237601/webrev.00/open/webrev/> \
> > > Cheers, Mikael


[prev in list] [next in list] [prev in thread] [next in thread]