[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: JDK 14 RFR of JDK-8230337: Clarify intention of Elements.{getPackageOf, getModuleOf}
From:       Joe Darcy <joe.darcy () oracle ! com>
Date:       2019-08-30 18:27:24
Message-ID: eb531208-f409-f5c4-0430-fb1fec838707 () oracle ! com
[Download RAW message or body]

On 8/30/2019 11:07 AM, Jonathan Gibbons wrote:
> 
> Style typo, but otherwise OK.
> 
> http://cr.openjdk.java.net/~darcy/8230337.2/test/langtools/tools/javac/processing/model/util/elements/TestGetPackageOf.java.sdiff.html
>  
> 65 for(var testCase : testCases.entrySet()) {
> add space between 'for' and '('.
> 
> -

Addressed before pushing; thanks,

-Joe


[Attachment #3 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 8/30/2019 11:07 AM, Jonathan Gibbons
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:5c42216e-ac03-81a7-5a34-517127af2206@oracle.com">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <p>Style typo, but otherwise OK.</p>
      <p><a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/~darcy/8230337.2/test/langtools/tools/javac/processing/model/util/elements/TestGetPackageOf.java.sdiff.html"
  moz-do-not-send="true">http://cr.openjdk.java.net/~darcy/8230337.2/test/langtools/to \
ols/javac/processing/model/util/elements/TestGetPackageOf.java.sdiff.html</a><span  \
class="changed" style="color: blue;"></span><br  class="Apple-interchange-newline">
        <span class="changed" style="color: blue;"></span></p>
      <pre style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; \
word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; \
text-decoration: none;"><span class="changed" style="color: blue;">  65             \
for(var testCase : testCases.entrySet()) {</span></pre>  <div \
class="moz-cite-prefix">add space between 'for' and '('.</div>  <div \
class="moz-cite-prefix"><br>  </div>
      <div class="moz-cite-prefix">-</div>
    </blockquote>
    <p>Addressed before pushing; thanks,</p>
    <p>-Joe<br>
    </p>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic