[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    RFR: JDK-8177068: incomplete classpath causes NPE in Flow
From:       Jan Lahoda <jan.lahoda () oracle ! com>
Date:       2019-08-28 14:12:35
Message-ID: 6b9e7075-51f7-0642-2296-8e18e11132de () oracle ! com
[Download RAW message or body]

Hi,

If a class cannot be load during speculative attribution due to a 
CompletionFailure, the CompletionFailure may not be happening again 
during the ordinary attribution, which may lead to errors not being 
reported (as the error is a consequence of the CompletionFailure). 
Producing the error only on CompletionFailures helps with error recovery 
by not producing unnecessary errors. A similar problem with completion 
in user code was solved by restoring the ClassSymbol for which the 
completion failed to the original state when the user code finishes. 
Something similar could be done for speculative attribution, undoing 
the completion for ClassSymbols which fail to complete during 
speculative attribution, so that their completion will fail again during 
ordinary attribution and the error is reported properly.

Proposed webrev: http://cr.openjdk.java.net/~jlahoda/8177068/webrev.00
JBS: https://bugs.openjdk.java.net/browse/JDK-8177068

How does this look?

Thanks,
     Jan
[prev in list] [next in list] [prev in thread] [next in thread]