[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Scope's usage of Filter<Symbol>
From:       Ron Shapiro <ronshapiro () google ! com>
Date:       2019-06-06 14:26:05
Message-ID: CACA6h9tQVVWMH+sjdaet2ZutmHX0g0mWhtEGX1BK8wWdkPnF5A () mail ! gmail ! com
[Download RAW message or body]

Hi,

I'm trying to experiment solutions to
https://bugs.openjdk.java.net/browse/JDK-8224161, and the intertwining of
Filter<Symbol> in Scope is making it hard for me to (a) understand the code
and (b) attempt a refactoring. I feel that the code will be simpler if we
extract the filtering logic to Filter.java itself, which can have a
Filter.filter(Iterable) method that uses Iterators.createFilterIterator.
That seems like an appropriate place to be filtering so that Scope has
fewer responsibilities.

I was wondering if this idea resonates. If so, I'll send a webrev as a
prefactoring.

Thanks,
Ron

[Attachment #3 (text/html)]

<div dir="ltr">Hi,<br><div><br></div><div>I&#39;m trying to experiment solutions to  \
<a href="https://bugs.openjdk.java.net/browse/JDK-8224161" \
class="cremed">https://bugs.openjdk.java.net/browse/JDK-8224161</a>, and the \
intertwining of Filter&lt;Symbol&gt; in Scope is making it hard for me to (a) \
understand the code and (b) attempt a refactoring. I feel that the code will be \
simpler if we extract the filtering logic to Filter.java itself, which can have a \
Filter.filter(Iterable) method that uses Iterators.createFilterIterator. That seems \
like an appropriate place to be filtering so that Scope has fewer \
responsibilities.</div><div><br></div><div>I was wondering if this idea resonates. If \
so, I&#39;ll send a webrev as a \
prefactoring.</div><div><br></div><div>Thanks,</div><div>Ron</div></div>



[prev in list] [next in list] [prev in thread] [next in thread]