[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: JDK 10 RFR of JDK-8172818: Add since=9 deprecation information to javax.lang.model classes
From:       Vicente Romero <vicente.romero () oracle ! com>
Date:       2017-10-26 23:05:09
Message-ID: 575c1126-81ed-7c4e-d2b5-55d2dec1482c () oracle ! com
[Download RAW message or body]

looks good,

Vicente

On 10/26/2017 01:13 PM, joe darcy wrote:
> Hello,
>
> Now that JDK 10 is used JDK 9 for bootstrapping, the deprecated 
> elements in the java.compiler package can indicate the new-in-9 
> "since" information for a deprecated annotation. (Since java.compiler 
> is compiled using the boot JDK, in JDK 9 the since information could 
> not be included because Deprecated.since is not usable with JDK 8.)
>
> Unix tools find, grep, sed, etc. were used to locate and replace
>
>     @Deprecated
>
> with
>
> @Deprecated(since="9")
>
> in the java.compiler module.
>
> Patch below. I'll double-check the copyright years before pushing.
>
> Thanks,
>
> -Joe
>
>
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java
> --- 
> a/src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ 
> b/src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -75,7 +75,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected AbstractAnnotationValueVisitor6() {}
>
>      /**
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor6.java
> --- 
> a/src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor6.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ 
> b/src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor6.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -75,7 +75,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected AbstractElementVisitor6(){}
>
>      /**
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java
> --- 
> a/src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ 
> b/src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -74,7 +74,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected AbstractTypeVisitor6() {}
>
>      /**
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor6.java
> --- 
> a/src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor6.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ 
> b/src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor6.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -91,7 +91,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected ElementKindVisitor6() {
>          super(null);
>      }
> @@ -104,7 +104,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected ElementKindVisitor6(R defaultValue) {
>          super(defaultValue);
>      }
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/lang/model/util/ElementScanner6.java
> --- 
> a/src/java.compiler/share/classes/javax/lang/model/util/ElementScanner6.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ 
> b/src/java.compiler/share/classes/javax/lang/model/util/ElementScanner6.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -106,7 +106,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected ElementScanner6(){
>          DEFAULT_VALUE = null;
>      }
> @@ -119,7 +119,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected ElementScanner6(R defaultValue){
>          DEFAULT_VALUE = defaultValue;
>      }
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java
> --- 
> a/src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ 
> b/src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -92,7 +92,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected SimpleAnnotationValueVisitor6() {
>          super();
>          DEFAULT_VALUE = null;
> @@ -106,7 +106,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected SimpleAnnotationValueVisitor6(R defaultValue) {
>          super();
>          DEFAULT_VALUE = defaultValue;
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor6.java
> --- 
> a/src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor6.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ 
> b/src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor6.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -94,7 +94,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected SimpleElementVisitor6(){
>          DEFAULT_VALUE = null;
>      }
> @@ -107,7 +107,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected SimpleElementVisitor6(R defaultValue){
>          DEFAULT_VALUE = defaultValue;
>      }
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java
> --- 
> a/src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ 
> b/src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -94,7 +94,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected SimpleTypeVisitor6(){
>          DEFAULT_VALUE = null;
>      }
> @@ -107,7 +107,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected SimpleTypeVisitor6(R defaultValue){
>          DEFAULT_VALUE = defaultValue;
>      }
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor6.java
> --- 
> a/src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor6.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ 
> b/src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor6.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -85,7 +85,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected TypeKindVisitor6() {
>          super(null);
>      }
> @@ -99,7 +99,7 @@
>       * @deprecated Release 6 is obsolete; update to a visitor for a 
> newer
>       * release level.
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      protected TypeKindVisitor6(R defaultValue) {
>          super(defaultValue);
>      }
> diff -r fd458b0b7749 
> src/java.compiler/share/classes/javax/tools/ToolProvider.java
> --- a/src/java.compiler/share/classes/javax/tools/ToolProvider.java 
> Wed Oct 25 10:40:45 2017 -0700
> +++ b/src/java.compiler/share/classes/javax/tools/ToolProvider.java 
> Thu Oct 26 10:10:19 2017 -0700
> @@ -96,7 +96,7 @@
>       * locate system tools as well as user-installed tools.
>       * @return a class loader, or {@code null}
>       */
> -    @Deprecated
> +    @Deprecated(since="9")
>      public static ClassLoader getSystemToolClassLoader() {
>          return null;
>      }
>


[prev in list] [next in list] [prev in thread] [next in thread]