[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: 8173393: Module system implementation refresh (2/2017)
From:       Peter Levart <peter.levart () gmail ! com>
Date:       2017-02-10 16:38:59
Message-ID: 79a3a721-64e1-e526-1e51-9dc4b897c0a9 () gmail ! com
[Download RAW message or body]

On 02/10/2017 02:49 PM, Alan Bateman wrote:
>> Here's what you could do:
>>
>> http://cr.openjdk.java.net/~plevart/jdk9-jake/AccessibleObject.canAccess_caching/webrev.01/ 
>>
> Good idea. Do you want to create an issue for this and follow-up on 
> core-libs-dev? The changes are in jdk9/dev now so it can follow. A 
> minor nit is that the InternalError was useful to catch bad changes, a 
> NPE could work too but it should never happen.
>
> -Alan 

Ok, will create an issue and a follow-up change.

Regards, Peter


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    <br>
    <div class="moz-cite-prefix">On 02/10/2017 02:49 PM, Alan Bateman
      wrote:<br>
    </div>
    <blockquote
      cite="mid:e2c187c3-8264-df55-09c7-77af3707e0e4@oracle.com"
      type="cite">
      <blockquote type="cite" style="color: #000000;">Here's what you
        could do:
        <br>
        <br>
        <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eplevart/jdk9-jake/AccessibleObject.canAccess_cachi \
ng/webrev.01/">http://cr.openjdk.java.net/~plevart/jdk9-jake/AccessibleObject.canAccess_caching/webrev.01/</a>
  <br>
      </blockquote>
      Good idea. Do you want to create an issue for this and follow-up
      on core-libs-dev? The changes are in jdk9/dev now so it can
      follow. A minor nit is that the InternalError was useful to catch
      bad changes, a NPE could work too but it should never happen.
      <br>
      <br>
      -Alan
    </blockquote>
    <br>
    Ok, will create an issue and a follow-up change.<br>
    <br>
    Regards, Peter<br>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic