[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-compiler-dev
Subject: RE: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed
From: Iris Clark <iris.clark () oracle ! com>
Date: 2016-07-21 21:01:52
Message-ID: f06bed61-6580-438e-a488-15b5ccb03538 () default
[Download RAW message or body]
Hi, Kumar.
Thank you very much for pushing the changesets to resolve this bug!
Regards.
iris
From: Iris Clark
Sent: Wednesday, July 20, 2016 1:11 PM
To: Kumar Srinivasan; Java Core Libs; compiler-dev@openjdk.java.net; \
kulla-dev@openjdk.java.net
Subject: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be \
renamed
Hi.
Please review changes in jdk and langtools (module jdk.jshell) to address the \
following bug:
8161236: Runtime.Version.{compareTo,equals}IgnoreOpt should be renamed
https://bugs.openjdk.java.net/browse/JDK-8161236
Webrev:
http://cr.openjdk.java.net/~iris/verona/8161236/webrev.0/
We update the method declarations to replace the token "Opt" with "Optional", thus \
aligning the method names with the associated getter, Runtime.Version.optional(). \
Specification references to those methods and any uses of the methods were also \
updated.
JPRT runs (testsets hotspot and pit) show no failures related to these changes. A \
CCC request is in flight.
Regards,
Iris
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" \
CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div \
class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Hi, \
Kumar.<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>Thank you very much for pushing the changesets to resolve this \
bug!<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>Regards.<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>iris<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Iris Clark \
<br><b>Sent:</b> Wednesday, July 20, 2016 1:11 PM<br><b>To:</b> Kumar Srinivasan; \
Java Core Libs; compiler-dev@openjdk.java.net; \
kulla-dev@openjdk.java.net<br><b>Subject:</b> RFR(s) 8161236: \
Runtime.Version.{compareTo, equals}IgnoreOpt should be \
renamed<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>Hi.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>Please review changes in jdk and langtools (module jdk.jshell) to \
address the following bug:<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal style='margin-left:.5in'>8161236: \
Runtime.Version.{compareTo,equals}IgnoreOpt should be renamed<o:p></o:p></p><p \
class=MsoNormal style='margin-left:.5in'><a \
href="https://bugs.openjdk.java.net/browse/JDK-8161236">https://bugs.openjdk.java.net/browse/JDK-8161236</a><o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Webrev:<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal style='margin-left:.5in'><a \
href="http://cr.openjdk.java.net/~iris/verona/8161236/webrev.0/">http://cr.openjdk.java.net/~iris/verona/8161236/webrev.0/</a><o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>We update the method \
declarations to replace the token “Opt” with “Optional”, thus \
aligning the method names with the associated getter, \
Runtime.Version.optional(). Specification references to those methods and any \
uses of the methods were also updated.<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>JPRT runs (testsets hotspot \
and pit) show no failures related to these changes. A CCC request is in \
flight.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>Regards,<o:p></o:p></p><p class=MsoNormal>Iris<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic