[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-compiler-dev
Subject:    Re: Request for review/advice from langtools team<was> Re: Covariant overrides on the Buffer Hierarc
From:       Paul Sandoz <paul.sandoz () oracle ! com>
Date:       2014-10-29 8:51:37
Message-ID: A98471D9-EB73-4FF6-B352-25C939B38B88 () oracle ! com
[Download RAW message or body]

On Oct 28, 2014, at 1:59 PM, Joel Borggrén-Franck <joel.franck@oracle.com> wrote:

> Hi Paul,
> 
> Sorry for the delay.
> 
> So if I understand this correctly, we get 4 warnings (and because of -Werror a \
> build failure) in langtools when compiling vs Jdk 9, but need the casts because we \
> bootstrap with Jdk 8. 

Yes.


> Looks good to me but I would prefer if you filed a bug on me for Jdk 10 for \
> removing the SuppressWarnings and added comments pointing to the bug after the \
> @SuppressWarnings annotations. That way I will remember to clean this up when we \
> bootstrap with Jdk 9. 

Ok, after i push i will log a new P4 bug and assign it to you.

Thanks,
Paul.


["signature.asc" (signature.asc)]

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIcBAEBAgAGBQJUUKqZAAoJEAPxyzLE7ykSyNwP/1lNUZehFheq8Z9r1V7L7ywP
c/Tji1yD8noB1ise61qpPvK+UXwcOFog2xG2qnCom5z5X/0Rw/mesmnfbyUYed1U
m8NhxCSPXzlJf1LNklMM6yPYf899kSjNOggTMk5w9isFmjq1gbxRwDVKQAtk0yt9
feHA4gA6D0y7LjsqCfjt4VJaFPo9k9blUYk9quaXrMHfyungSSPE8C+LvuKaz3IS
Wd5wR3CNbflv1NlM0FH7K7PyOfsdVukk2jTQp8b6A0Csw3rUoQgJAzwqneHstplQ
QJI4upvxlDAjFeGE5VCe9JfURt0jUDjh2EWSuzkD87g7jbEFMQ5tWS2TsTIlkY+R
QUlPxOjkLhHf8atqHRFXrwCZHZKEvrzEimw9IcdZKp2F6yNqou2X+YTW/d3KwNhR
C6LvJ3lZJj1tPlvqUT9E19/PXI1fhws25qoD86FEs2pUj2S2Zr/f9Ilqo1AYPNcg
pG0ByHVrICffIuS9td3gZD1ot8yLtLjubZpeV6sVS78TVcWZeQWYyb+Xjk0XYeyy
yktP51fl0hQWquVxZAsq1C5gJ9k4JBTsh6KsazCRI0GRim8sKZXcrUUKkwakn48z
il/u+V4RjpEDsApFyDSoeoV5Q90CmfhVaVfW0mTdcKcbdXc0MwbcZAblW6TL8sVM
a3l/WfhXaMFzHiNPPml+
=4FMc
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic