[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Re: RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX [v2]
From:       Deepa Kumari <duke () openjdk ! org>
Date:       2023-09-21 6:06:52
Message-ID: W_HUKMlTfb8bz5DsLne6Jnu27oF6VrPe5ynyrrX7UEk=.89617934-c825-4b1a-a888-37c4db9b8860 () github ! com
[Download RAW message or body]

On Wed, 20 Sep 2023 10:21:36 GMT, Deepa Kumari <duke@openjdk.org> wrote:

> > Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , the \
> > AIX build process raised complaints about the disk location detection, \
> > incorrectly determining that the build wasn't on a local disk. However, a partial \
> > fix introduced a new problem, the build process consistently reports that it's on \
> > a local disk, even when it's not The core problem here seems to be that Bash \
> > treats quoted commands as string literals, and it only evaluates them if you use \
> > 'eval' directly. The  change ensure that Bash correctly evaluates the **DF** \
> > variable as a command. 
> > Reported Issue : [JDK-8315786](https://bugs.openjdk.org/browse/JDK-8315786)
> 
> Deepa Kumari has updated the pull request incrementally with one additional commit \
> since the last revision: 
> remove quotes

> Seems reasonable.
> 
> Thanks Deepa for fixing it.
> 
> /sponsor

Thank you @offamitkumar.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15592#issuecomment-1728908477


[prev in list] [next in list] [prev in thread] [next in thread]