[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Re: RFR: 8294310: compare.sh fails on macos after JDK-8293550
From:       Magnus Ihse Bursie <ihse () openjdk ! org>
Date:       2022-09-27 14:36:30
Message-ID: _S7KrZsXStfdL96iEg4u4ssSI4OAUEBik1MeKAK0xIw=.5d7c3b99-fa19-4c49-88f5-0585cf892fc4 () github ! com
[Download RAW message or body]

On Mon, 26 Sep 2022 22:51:22 GMT, Erik Joelsson <erikj@openjdk.org> wrote:

> Since [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) we are adding \
> adhoc signatures to all binaries on macos, and the compare script is no longer \
> running cleanly. In order to compare binaries on macos, especially on aarch64, \
> where signatures are mandatory, we will have to remove them first. They will never \
> be exactly the same between two runs. 
> This patch adds `codesign --remove-signature` to compare.sh before comparing any \
> executables or libraries. Stripping the signature has to happen after running \
> `strip` as strip will fail otherwise. I also had to add a special option to strip \
> to avoid warnings. 
> While enabling baseline compare runs for macosx-aarch64 in our CI, I discovered \
> that were also not running testmake for aarch64, so I snuck in that change in \
> jib-profiles.js here as well.

Marked as reviewed by ihse (Reviewer).

Ok. Sigh. This is really a step backwards in reproducability. But the fault lies with \
Apple, and we can't do much about it.

-------------

PR: https://git.openjdk.org/jdk/pull/10435


[prev in list] [next in list] [prev in thread] [next in thread]