[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Integrated: 8273072: Avoid using += in configure
From:       Magnus Ihse Bursie <ihse () openjdk ! java ! net>
Date:       2021-08-27 13:58:10
Message-ID: p0xfppLj4nAq3Ceiy9k9V5gDKu1rmeYqXKWycdlvPUI=.5ad1e7f4-73d2-4ecf-8977-da53f2970f53 () github ! com
[Download RAW message or body]

On Fri, 27 Aug 2021 10:21:26 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:

> JDK-8272700 was created to fix a bug in a variable assignment in configure. While \
> it fixed the bug, it kept the problematic syntax that caused the bug in the first \
> place.  
> We do not use the `FOO+="appended"` syntax for appending to variables in shell \
> scripts, since this differs from what you'd expect (and what make produces) in that \
> no space is added before the appended text.  
> Instead, we use the longer, but clearer `FOO="$FOO appended"`.

This pull request has now been integrated.

Changeset: a033aa5a
Author:    Magnus Ihse Bursie <ihse@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/a033aa5a3d9c63d72d11af218b9896b037fbd8de
                
Stats:     8 lines in 4 files changed: 1 ins; 0 del; 7 mod

8273072: Avoid using += in configure

Reviewed-by: dholmes, jiefu

-------------

PR: https://git.openjdk.java.net/jdk/pull/5276


[prev in list] [next in list] [prev in thread] [next in thread]