[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v2]
From:       Erik Joelsson <erikj () openjdk ! java ! net>
Date:       2020-11-30 15:46:58
Message-ID: m5KdIZFS3vxqpvImobjesvU849cYjKqo7An4kVXfWpg=.823ecd78-c275-4ada-b6ad-e1345942fc4d () github ! com
[Download RAW message or body]

On Mon, 23 Nov 2020 15:19:18 GMT, Bernhard Urban-Forster <burban@openjdk.org> wrote:

> > I think you need to wait for #1350, and then reconcile this patch with that \
> > refactoring.
> 
> Thanks for all the comments.
> 
> > - 40-50 min builds seem to be excessive for just the hotspot build, do youknow \
> > what exactly takes that long? Is this for release and debug each or both \
> > combined?
> 
> It's for each of them. Installing a specific version of MSVC and creating the \
> devkit take each ~10min. Thinking about it,  there is a opportunity to cache the \
> devkit and do the MSVC installer invocation only if no cached devkit is available. 
> Here is an example run if you want to have a closer look:
> https://github.com/lewurm/openjdk/runs/1434118318?check_suite_focus=true
> 
> > - Is it worth the cycles to build both release *and* debug? How probable is
> it that a non-win-aarch-dev will break one but not the other? I presume
> developers on the windows aarch project will have tested the build locally
> before pushing.
> 
> Fair, I'll remove one of them (as suggested by Aleksey in another comment, I'll \
> keep the debug one).

Generating a devkit every time we build seems like a pretty big waste of time. The \
OpenJDK build is expected to work without devkits, using an installed Visual Studio. \
Is this not possible with the Windows aarch64 build? If not, then that really should \
be fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1379


[prev in list] [next in list] [prev in thread] [next in thread]