[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Re: RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols [v3]
From:       Jan Lahoda <jlahoda () openjdk ! java ! net>
Date:       2020-11-30 14:27:13
Message-ID: bGe6Plxy_wMV2aISRvW1XiJoaWu9Wxr2JF_41pn-No8=.2e18b5f7-6f0b-4df0-98fd-bcb074be762e () github ! com
[Download RAW message or body]

On Mon, 30 Nov 2020 12:17:46 GMT, Chris Hegarty <chegar@openjdk.org> wrote:

> > Jan Lahoda has updated the pull request incrementally with one additional commit \
> > since the last revision: 
> > Fixing tests on Windows - normalizing line endings.
> 
> make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java line 965:
> 
> > 963:                            new NestMembers_attribute(attributeString, \
> >                 nestMembers));
> > 964:         }
> > 965:         if (header.recordComponents != null && \
> > !header.recordComponents.isEmpty()) {
> 
> I am not sure of the exact logic here, but it is perfectly fine for a record \
> attribute to contain zero components, and for the class to still be considered a \
> "record class". But maybe that is not all that significant here? I just want to \
> call it out so that it is considered.

Ah, right - fixed in:
https://github.com/openjdk/jdk/pull/1480/commits/e1ec2b7ff49e1307a348ad58b12e5ed39ebe7224


Thanks for the comment!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1480


[prev in list] [next in list] [prev in thread] [next in thread]