[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Re: [11u] RFR: 8240073: Fix 'test-make' build target in 11u
From:       Volker Simonis <volker.simonis () gmail ! com>
Date:       2020-02-28 9:24:45
Message-ID: CA+3eh10us=nLm8tk_s8RH9ALHtY=deL1kvYidk+i5+bOobgDsQ () mail ! gmail ! com
[Download RAW message or body]

On Wed, Feb 26, 2020 at 5:21 PM Hohensee, Paul <hohensee@amazon.com> wrote:
>
> Looks to me like the replaced store to KEYWORDS is dead (i.e., no uses of=
 KEYWORDS that I could find in make and test/make). Lgtm.

Yes, that's exactly why we need this patch :)

"ParseKeywordVariableBody" in "make/common/MakeBase.gmk" initially
used "KEYWORDS" but when it was updated by "8212028: Use run-test
makefile framework for testing in Oracle's Mach5" to use
"SINGLE_KEYWORDS" instead, these two places were forgotten.

Thanks for reviewing,
Volker

>
> Thanks,
> Paul
>
> =EF=BB=BFOn 2/26/20, 3:19 AM, "build-dev on behalf of Volker Simonis" <bu=
ild-dev-bounces@openjdk.java.net on behalf of volker.simonis@gmail.com> wro=
te:
>
>     Hi,
>
>     can I please have a review for the following tiny change which fixes
>     the 'test-make' build target in 11u:
>
>     http://cr.openjdk.java.net/~simonis/webrevs/2020/8240073/
>     https://bugs.openjdk.java.net/browse/JDK-8240073
>
>     This is a tiny fix for a problem introduced by JDK-8212028 (which has
>     already been downported to 11u) and fixed in jdk 12 as part of
>     JDK-8210958 (which hasn't been downported yet and probably won't be
>     donwported at all).
>
>     Instead of smuggling this fix into another downport, it has been
>     argued (https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-=
February/002533.html)
>     that it is cleaner to create an explicit issue for fixing it in 11u.
>
>     The fix is trivial (that's why it was done as part of JDK-8210958
>     without an extra bug ID) and only affects running "make test-make".
>
>     Thank you and best regards,
>     Volker
>
>
[prev in list] [next in list] [prev in thread] [next in thread]