[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Re: RFR: JDK-8213362 : Could not find libjava.dylib error when initializing JVM via JNI_CreateJavaVM
From:       Henry Jen <henry.jen () oracle ! com>
Date:       2018-11-30 21:31:57
Message-ID: 9DC38CB7-A5D3-4ADD-87F4-8E10E5937695 () oracle ! com
[Download RAW message or body]

Thanks for the review, Alan and Magnus.

Cheers,
Henry

> On Nov 30, 2018, at 7:20 AM, Alan Bateman <Alan.Bateman@oracle.com> wrote:
> 
> 
> 
> On 28/11/2018 22:49, Henry Jen wrote:
> > Since there is no header file in JDK provides the function prototypes, I don't \
> > think this is considered public(supported) APIs. 
> > Anyway, in case a tools is build with launcher code, and shipped separately from \
> > JDK, that would be impacted by this bug. So I added a test call JLI_Launch as \
> > well. Please review the updated webrev[1]. 
> > Note that, JLI_Launch should not be used directly as it does't handle the \
> > argument processing which is done in launcher/main.c. 
> > Cheers,
> > Henry
> > 
> > [1] http://cr.openjdk.java.net/~henryjen/jdk12/8213362.1/webrev/
> > 
> Updated webrev looks okay. I do find the exeXXX convention for the launchers \
> created in the test make files very strange but this is something we can chase up \
> with another issue. 
> -Alan


[prev in list] [next in list] [prev in thread] [next in thread]