[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Re: RFR: 8146985: Change output directory for hotspot's jtreg tests
From:       Mikael Vidstedt <mikael.vidstedt () oracle ! com>
Date:       2016-01-15 19:53:21
Message-ID: 56994E31.7050600 () oracle ! com
[Download RAW message or body]


Looks good!

I suggest as a follow up change to align the variable names and the 
(JPRT) "else" part with jdk/test/Makefile.

Cheers,
Mikael

On 2016-01-15 08:13, Erik Helin wrote:
> Hi all,
>
> I have updated the patch based on feedback and comments.
> hotspot/test/Makefile is now aligned with jdk/test/Makefile and now
> stores the ouput from the jtreg tests in:
>    <top-level>/build/<conf>/testoutput/<jtreg-group>
> Since the jtreg groups are prefixed with the name of the repository,
> e.g. hotspot_svc, jdk_svc, there won't be any name clashes.
>
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8146985/01/
>
> Testing:
> - Running `make test-hotspot-jtreg` and verified that is uses the
>    correct directory for test output.
> - Running JPRT and verified that it works with the new directory name.
>    Since JPRT does not use ALT_OUTPUTDIR, the output will be stored in
>      build/<os>-<arch>/testoutput/<jtreg-group>
>    which JPRT seems to handle just fine.
>
> Thanks,
> Erik
>
> On 2016-01-13, Erik Helin wrote:
>> Hi all,
>>
>> this patch changes the output directory for hotspot's jtreg tests when
>> run via the top-level Makefile targets such as
>> `make test-hotspot-jtreg`.
>>
>> The current directory is
>> <top-level>/build/<conf>/hotspot/linux-x64/testoutput
>> (on an x86-64 machine running Linux). There is no need to place the
>> "testoutput" directory in a directory which name is based on OS and arch,
>> that is already done by the current configuration. Therefore, we can
>> instead place the "testoutput" directory in
>> <top-level>/build/<conf>/hotspot/, which is a more reasonable location
>> for the output from hotspot's tests.
>>
>> Enhancement:
>> https://bugs.openjdk.java.net/browse/JDK-8146985
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8146985/00/webrev
>>
>> Testing:
>> - Running `make test-hotspot-jtreg` locally
>> - JPRT (the patch does not affect JPRT since JPRT does not use
>>    ALT_OUTPUTDIR)
>>
>> Thanks,
>> Erik

[prev in list] [next in list] [prev in thread] [next in thread]