[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Re: RFR: JDK-8136764 ORIGINAL_PATH is broken if PATH contains directory with "#" in it's name
From:       Tim Bell <tim.bell () oracle ! com>
Date:       2015-09-18 16:31:03
Message-ID: 55FC3C47.3010808 () oracle ! com
[Download RAW message or body]

Hello Magnus:

> If the PATH contains a directory with a # in it's name, we will store 
> ORIGINAL_PATH=...#... in spec.gmk.
>
> However, this will result in make cutting the line at #, believing the 
> rest to be a comment.
>
> Unfortunately, having directories named # is not so esoteric it at 
> first seems, since Microsoft Visual Studio typically adds it's F# 
> implementation to the PATH. :-(

Too bad.

> Bug: https://bugs.openjdk.java.net/browse/JDK-8136764
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8136764-escape-hash-in-ORIGINAL_PATH/webrev.01

Looks good to me.

Hopefully the issue will stay fixed this time.  The previous attempt was 
in JDK-8009315.

Tim

[prev in list] [next in list] [prev in thread] [next in thread]