[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Re: RFR: JDK-8058631 Rename posix to unix in build system to match file name changes
From:       Tim Bell <tim.bell () oracle ! com>
Date:       2014-11-18 15:56:18
Message-ID: 546B6C22.6080501 () oracle ! com
[Download RAW message or body]

Magnus:

Looks good to me as well.

Tim

On 11/18/14 04:41, Erik Joelsson wrote:
> This version looks good to me.
>
> /Erik
>
> On 2014-11-05 14:04, Magnus Ihse Bursie wrote:
>> On 2014-09-24 14:39, Magnus Ihse Bursie wrote:
>>> After Jigsaw M1, there is a new common "unix" directory structure. 
>>> We have used "posix" in the build system for the same purpose, but 
>>> this leads to unnecessary conversations. Instead, we should use 
>>> "unix" all way through in the build system.
>>>
>>> Also, this means that OS_API is slightly misleading -- we're not 
>>> actually checking for an API such as POSIX, but the general category 
>>> of OSes. I'll rename the *_OS_API to *_OS_TYPE instead. The "winapi" 
>>> OS_API was never used, and is removed -- we only need to check for 
>>> "windows", there's no need to introduce an abstract "winapi" category.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8058631
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8058631-rename-posix-to-unix/webrev.01
>>
>> This fix got stuck far down the priority list...
>>
>> It was pointed out to me that OS_API_SRC_DIRS should change name as 
>> well, to match OS_TYPE. This updated webrev contain that fix. I have 
>> also double-checked that no other name changes are needed to keep the 
>> code consistent.
>>
>> Updated webrev:
>> http://cr.openjdk.java.net/~ihse/JDK-8058631-rename-posix-to-unix/webrev.02/ 
>>
>>
>> /Magnus
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]