[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable
From:       erik.joelsson () oracle ! com (Erik Joelsson)
Date:       2012-02-16 8:20:48
Message-ID: 4F3CBC60.5000707 () oracle ! com
[Download RAW message or body]

On 2012-02-16 07:21, David Holmes wrote:
> On 16/02/2012 1:06 AM, Erik Joelsson wrote:
>> New webrev:
>> http://cr.openjdk.java.net/~erikj/7141244/webrev.04/
>> 175 lines changed: 87 ins; 29 del; 59 mod; 3970 unchg
>>
>> I discovered that the -include $(SPEC) line needed to be added to the
>> make/{bsd,solaris,linux}/makefiles/buildtree.make files. Otherwise the
>> hotspot build won't respect setting OPENJDK=true in the spec.
>
> Is that the only change from version 3?
>
That is the only change yes.
> Have you verified you can do all three variants: openjdk, jdk, 
> embedded jdk?
>
Not sure how you mean. The problem I corrected was discovered during 
development in the build-infra repo, where I'm currently working on the 
open vs non open scenarios. We haven't started looking at embedded much 
yet (build-infra isn't currently building on anything but linux atm). 
This issue, and the change, has no impact on the old build system, 
either building just hotspot or from the root repo. I'm running my 
hotspot-rt through jprt now anyway to be sure.

/Erik



[prev in list] [next in list] [prev in thread] [next in thread]