[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-build-dev
Subject:    Bug 100028 -  Debug information is incomplete or missing
From:       aph () redhat ! com (Andrew Haley)
Date:       2009-03-31 14:13:59
Message-ID: 49D22527.5010104 () redhat ! com
[Download RAW message or body]

Kelly O'Hair wrote:
> 
> Seems ok to me, just a few observations:
> 
> Do we need this:
> 
> ifeq ($(DEBUG_CLASSFILES), true)
>   ANT_OPTIONS += -Djavac.debug=true
>   ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars
> endif
> 
> to be
> 
> ifeq ($(DEBUG_CLASSFILES), true)
>   ANT_OPTIONS += -Djavac.debug=true
>   ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars
> else
>   ANT_OPTIONS += -Djavac.debug=false
>   ANT_OPTIONS += -Djavac.debuglevel=
> endif
> 
> Not sure what happens in ant if a property is not set but used???.

Actually, I don't think we do.

This would lead to

ifeq ($(VARIANT), DBG)
  ANT_OPTIONS += -Djavac.debug=true
else
  ifeq ($(VARIANT), OPT)
    ANT_OPTIONS += -Djavac.debug=false
  endif
endif

ifeq ($(DEBUG_CLASSFILES), true)
  ANT_OPTIONS += -Djavac.debug=true
  ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars
else
  ANT_OPTIONS += -Djavac.debug=false
  ANT_OPTIONS += -Djavac.debuglevel=
endif

which would cause javac.debug=false if $(VARIANT) == DBG, wouldn't it?
Unless, I supoose, we can guarantee that if $(VARIANT) == DBG then
DEBUG_CLASSFILES == true.  And the build is such a maze of twisty passages
I'm not confident I could swear to that!

Andrew.


[prev in list] [next in list] [prev in thread] [next in thread]