[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: RFR: 8329210: Delete Redundant Printer Dialog Modality Test
From:       Phil Race <prr () openjdk ! org>
Date:       2024-03-28 16:02:31
Message-ID: tNCfGF3wCOEjZxeb6rYFmsa1Vl7f5Yi2_4wP_giFbvM=.7eb23e36-8384-420e-8755-b313b9f5d4c0 () github ! com
[Download RAW message or body]

On Wed, 27 Mar 2024 18:39:35 GMT, Damon Nguyen <dnguyen@openjdk.org> wrote:

> test/jdk/java/awt/print/Dialog/PrintModalDialog.java is too similar in \
> functionality to test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java.
>  
> One test was originally for modality in web browsers, while the other was for \
> modality in Windows OS printer dialogs, but after the updates, they both check for \
> modality on print and page dialogs for all OSs. 
> Since PrinterDialogsModalityTest.java is the preferred test, this is to remove \
> PrintModalDialog.java as a test. In addition, the bugID in the jtreg tags from \
> PrintModalDialog.java will be added to PrinterDialogsModalityTest.java's tags to \
> maintain a link to its original bug.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18524#pullrequestreview-1966620085


[prev in list] [next in list] [prev in thread] [next in thread]