[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: RFR: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
From:       Harshitha Onkar <honkar () openjdk ! org>
Date:       2022-06-22 18:54:21
Message-ID: X3WHIL6Qym5HRAqxQzkligC0b1pOaDjnzUoPdIqGWJ4=.332f1f25-b29f-4aa0-9222-21c9b7eaa5f4 () github ! com
[Download RAW message or body]

On Wed, 15 Jun 2022 05:37:42 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> > Harshitha Onkar has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > minor changes
> 
> test/jdk/java/awt/Frame/AwtFramePackTest.java line 42:
> 
> > 40:  * @bug 8265586
> > 41:  * @key headful
> > 42:  * @requires (os.family == "windows")
> 
> Any reason why the test is windows specific? It does not have the platform specific \
> code.

@mrserb Since the PR was already integrated before the review suggestion was made to \
make the test generic, a new PR has been created to remove the `@requires` tag from \
the test. 

PR link: https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9248__;!!ACWV \
5N9M2RV99hQ!MFn79i-DER0pt7vktu0YuA2JXKunu0coHlgVa2zAlCcpScyA7dyomdf_7YO2iKvexwrEpQkRtThzZWRSkDjQa9T5$ \
 JBS bug: https://bugs.openjdk.org/browse/JDK-8288993

-------------

PR: https://git.openjdk.org/jdk/pull/9118


[prev in list] [next in list] [prev in thread] [next in thread]