[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-awt-dev
Subject: <AWT Dev> Integrated: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
From: Phil Race <prr () openjdk ! java ! net>
Date: 2021-08-24 15:26:29
Message-ID: qXgHc7ckwCMONr0kz1l1jgEgeHKwezOpQgFUBlnPlZQ=.c0618825-381e-4a4f-9117-c577593dd113 () github ! com
[Download RAW message or body]
On Sun, 22 Aug 2021 19:46:49 GMT, Phil Race <prr@openjdk.org> wrote:
> There's a long eval in the bug report : \
> https://bugs.openjdk.java.net/browse/JDK-8272806 but here's the summary
> When focus is lost by the app a message is sent down to native setting a native \
> reference to the input method to null which is a sort of signal not to notify \
> upwards anything to the input method (which internally will NPE if there's no \
> focused component as is the case after focus is lost). But we aren't actually \
> setting it to null because of a check for null which previously checked the wrapper \
> for the JNI ref was not null but is now obsolete. So just remove the check for \
> null.
> The steps to reproduce this bug are very manual and involve installing additional \
> input methods and toggling them at the system level. So I didn't see a way to write \
> a useful regression test but if you follow the bug report steps you should be able \
> to verify the fix.
> I've run all automated tests just for good measure and they all pass.
This pull request has now been integrated.
Changeset: f681d654
Author: Phil Race <prr@openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/f681d6544ac2506cb72e45c1f9ed8dfbbde099f2
Stats: 4 lines in 2 files changed: 1 ins; 2 del; 1 mod
8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
Reviewed-by: serb, dmarkov, azvegint
-------------
PR: https://git.openjdk.java.net/jdk/pull/5211
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic