[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> RFR: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibil
From:       Anton Tarasov <ant () openjdk ! java ! net>
Date:       2021-08-09 16:37:46
Message-ID: iY8oTJ2nyi74SrBZcEjuX8yY9LTNo9poE7M0gEQkCvs=.518648d5-f7d8-4672-aa54-2adb43eadb5d () github ! com
[Download RAW message or body]

On Mon, 2 Aug 2021 09:00:14 GMT, Artem Semenov \
<github.com+36081106+savoptik@openjdk.org> wrote:

> > 8267385: Create NSAccessibilityElement implementation for \
> > JavaComponentAccessibility This pull request contains solutions for the following \
> >                 tickets:
> > * JDK-8267385 Create NSAccessibilityElement implementation for \
> >                 JavaComponentAccessibility;
> > * JDK-8262031 Create implementation for NSAccessibilityNavigableStaticText \
> >                 protocol;
> > * JDK-8264287 Create implementation for NSAccessibilityComboBox protocol peer;
> > * JDK-8264303 Create implementation for NSAccessibilityTabGroup protocol peer;
> > * JDK-8264292 Create implementation for NSAccessibilityList protocol peer;
> > * JDK-8267387 Create implementation for NSAccessibilityOutline protocol;
> > * JDK-8267388 Create implementation for NSAccessibilityTable protocol.
> 
> Artem Semenov has updated the pull request incrementally with one additional commit \
> since the last revision: 
> 1. Fixed problems with vertical navigation in table cells;
> 2. I suggest doing the opposite, leave the CHECK_EXCEPTION and remove the chech and \
> the logging. The CHECK_EXCEPTION is better since it can be configured via \
> properties, and it will chech itself on what thread the current code is executed.

Thanks all for the thorough review and deep testing!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4412


[prev in list] [next in list] [prev in thread] [next in thread]