[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    <AWT Dev> Integrated: 8248532: Every time I change keyboard language at my MacBook, Java crashes
From:       Prasanta Sadhukhan <psadhukhan () openjdk ! java ! net>
Date:       2020-09-09 13:45:42
Message-ID: xVqqVdUaCM2MQqaEbeJNQ5o1fGV2xufHJ2ZqHHYWD-8=.854e27e2-ef03-4d5e-961b-e5c5fbb8b946 () github ! com
[Download RAW message or body]

On Sun, 6 Sep 2020 08:31:23 GMT, Prasanta Sadhukhan <psadhukhan@openjdk.org> wrote:

> It seems the observer either needs to be removed when it is dealloced/destroyed \
> (Otherwise Notification Centre would send the notification to the destroyed object \
> resulting in crash.) and we need to do the below in dealloc, which solves the crash \
> in my system. 
> NSNotificationCenter *nc = [NSNotificationCenter defaultCenter]; [nc \
> removeObserver:self] 
> But it is not done for LWCToolkit, so I changed the observer as is being done \
> there, to make existing @implementation class as observer

This pull request has now been integrated.

Changeset: 6329de45
Author:    Prasanta Sadhukhan <psadhukhan@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/6329de45
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8248532: Every time I change keyboard language at my MacBook, Java crashes

Reviewed-by: serb, prr

-------------

PR: https://git.openjdk.java.net/jdk/pull/28


[prev in list] [next in list] [prev in thread] [next in thread]