[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-awt-dev
Subject: Re: <AWT Dev> [14] RFR JDK-8234786: Fix for JDK-8214578 breaks OS X 10.12 compatibility
From: Philip Race <philip.race () oracle ! com>
Date: 2019-11-27 16:12:22
Message-ID: 5DDEA066.6020900 () oracle ! com
[Download RAW message or body]
+1
-phil
On 11/25/19, 9:25 PM, Prasanta Sadhukhan wrote:
> Hi All,
>
> Please review a fix for a compatibility issue introduced in
> JDK-8214578 where a type alias NSTextInputSourceIdentifier is used
> which is only present from osx10.13 onwards thereby breaking
> compatibility with osx10.12.
> Fix is to use the typedef NSString * instead of which
> NSTextInputSourceIdentifier is a type of
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8234786
>
> diff -r b256c7afe8cc
> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h
> --- a/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.hMon Nov
> 25 11:20:14 2019 +0530
> +++ b/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.hTue Nov
> 26 10:49:47 2019 +0530
> @@ -38,7 +38,7 @@
> // TODO: NSMenu *contextualMenu;
>
>
> // Keyboard layout
> - NSTextInputSourceIdentifier kbdLayout;
> + NSString *kbdLayout;
>
>
> // dnd support (see AppKit/NSDragging.h,
> NSDraggingSource/Destination):
> CDragSource *_dragSource;
>
> Regards
> Prasanta
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
+1<br>
<br>
-phil<br>
<br>
On 11/25/19, 9:25 PM, Prasanta Sadhukhan wrote:
<blockquote
cite="mid:1BCFAFD0-7A6F-4281-AE86-7124C2EA5A5F@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
Hi All,
<div class=""><br class="">
</div>
<div class="">Please review a fix for a compatibility issue
introduced in JDK-8214578 where a type alias
NSTextInputSourceIdentifier is used which is only present from
osx10.13 onwards thereby breaking compatibility with osx10.12.</div>
<div class="">Fix is to use the typedef NSString * instead of
which NSTextInputSourceIdentifier is a type of</div>
<div class=""><br class="">
</div>
<div class="">
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">Bug: <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8234786"
class="">https://bugs.openjdk.java.net/browse/JDK-8234786</a></span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""><br
class="">
</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">diff
-r b256c7afe8cc
src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">---
a/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h<span
class="Apple-tab-span" style="white-space:pre"> </span>Mon
Nov 25 11:20:14 2019 +0530</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+++
b/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h<span
class="Apple-tab-span" style="white-space:pre"> </span>Tue
Nov 26 10:49:47 2019 +0530</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">@@
-38,7 +38,7 @@</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
// TODO: NSMenu *contextualMenu;</span></div>
<p style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255); min-height: 13px;" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""> </span><br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
// Keyboard layout</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">-
NSTextInputSourceIdentifier kbdLayout;</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
NSString *kbdLayout;</span></div>
<p style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255); min-height: 13px;" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""> </span><br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
// dnd support (see AppKit/NSDragging.h,
NSDraggingSource/Destination):</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
CDragSource *_dragSource;</span></div>
</div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""><br
class="">
</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">Regards</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; background-color:
rgb(255, 255, 255);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">Prasanta</span></div>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic