[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> [12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints sta
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2019-11-01 0:04:25
Message-ID: 216928ad-f9cf-a421-d73d-6930a07b74b9 () oracle ! com
[Download RAW message or body]

Hello.
Please review an updated version of the fix for jdk14.

Bug: https://bugs.openjdk.java.net/browse/JDK-8210231
CSR: https://bugs.openjdk.java.net/browse/JDK-8230783
Fix: http://cr.openjdk.java.net/~serb/8210231/webrev.03

The logic of the method is skipped if the thread was interrupted already.

On 10/7/18 9:56 pm, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk12.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210231
> Webrev: http://cr.openjdk.java.net/~serb/8210231/webrev.00
> 
> The Robot.delay() is a simple wrapper on top of Thread.sleep(), which ignores the \
> InterruptedException. But in case of InterruptedException it prints the stack \
> trace, which is unspecified behavior. 
> In the fix the "printStackTrace()" was removed, and the interrupted state of the \
> thread is restored. 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]