[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-awt-dev
Subject: <AWT Dev> RFR [XS] 8229023: make java/awt/print/PrinterJob/SameService.java Windows-only ,
From: "Baesken, Matthias" <matthias.baesken () sap ! com>
Date: 2019-08-02 11:36:11
Message-ID: AM6PR02MB5078888DFBE9A6123544332B93D90 () AM6PR02MB5078 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
Hello, please review the following small test adjustment .
It makes the test java/awt/print/PrinterJob/SameService.java Windows-=
only.
Reason is that in some cases the print service is recreated on Linux .
( we observed this in ~ 30 % of test runs on one of our test machines )
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8229023
http://cr.openjdk.java.net/~mbaesken/webrevs/8229023.0/
Thanks, Matthias
Hello, I have a question regarding the test java/awt/PrinterJob/SameServ=
ice.java ; the test deals with @bug 6446094 .
It checks that print services are not re-created , which was address=
ed (or at least discussed ) in 6446094 ,
See
https://bugs.openjdk.java.net/browse/JDK-6446094
Win32PrintServiceLookup.getPrintServiceByName() should not recreate duplica=
te instances.
However 6446094 just talks about Windows , and I see sporadic failur=
es on some Linux test machine in java/awt/PrinterJob/SameService.java
because the print service is (seldom) recreated on Linux ( it is =
even non-deterministic, on the same machine the test fails in ~ 30 % of ru=
ns and succeeds in the other cases ) .
Can we make the test Windows-only ( I think the API does not guarante=
e that print services are not re-created , although it is desired )=
?
Best regards, Matthias
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
h1
{mso-style-priority:9;
mso-style-link:"Heading 1 Char";
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:24.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.Heading1Char
{mso-style-name:"Heading 1 Char";
mso-style-priority:9;
mso-style-link:"Heading 1";
font-family:"Calibri",sans-serif;
mso-fareast-language:DE;
font-weight:bold;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hello, please review the following \
small test adjustment .<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US">It \
makes the test \
java/awt/print/PrinterJob/SameService.java Windows-only. \
<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Reason is that in some cases the print service is recreated on \
Linux .<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US">( we observed \
this in ~ 30 % of test runs on one of our test machines )<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Bug/webrev :<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><a href="https://bugs.openjdk.java.net/browse/JDK-8229023"><span \
lang="EN-US">https://bugs.openjdk.java.net/browse/JDK-8229023</span></a><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><a \
href="http://cr.openjdk.java.net/~mbaesken/webrevs/8229023.0/"><span \
lang="EN-US">http://cr.openjdk.java.net/~mbaesken/webrevs/8229023.0/</span></a><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks, Matthias<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Hello, I have a question \
regarding the test java/awt/PrinterJob/SameService.java \
; the test deals with @bug 6446094 \
.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US">It \
checks that print services are not re-created , \
which was addressed (or at least discussed ) in 6446094 \
,<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US">See \
<o:p></o:p></span></p> <p class="MsoNormal"><a \
href="https://bugs.openjdk.java.net/browse/JDK-6446094"><span \
lang="EN-US">https://bugs.openjdk.java.net/browse/JDK-6446094</span></a><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span \
lang="EN-US">Win32PrintServiceLookup.getPrintServiceByName() should not recreate \
duplicate instances.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">However 6446094 just talks about Windows , and I \
see sporadic failures on some Linux test machine \
in java/awt/PrinterJob/SameService.java <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> because the print service \
is (seldom) recreated on Linux ( it is even \
non-deterministic, on the same machine the test fails in ~ 30 % of runs and \
succeeds in the other cases ) .<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US">Can we make the test Windows-only \
( I think the API does not guarantee \
that print services are not re-created , although it \
is desired ) ?<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US">Best regards, Matthias<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
lang="EN-US"><o:p> </o:p></span></p> </div>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic