[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-awt-dev
Subject: Re: <AWT Dev> [13] RFR 8214109: XToolkit is not correctly displayed color on 16-bit high color setti
From: Philip Race <philip.race () oracle ! com>
Date: 2019-02-25 18:08:08
Message-ID: 5C742F08.3040403 () oracle ! com
[Download RAW message or body]
Ok. Approved
-phil.
On 2/25/19, 1:42 AM, Dmitry Markov wrote:
> That's right. I ran corresponding regression tests on Ubuntu and I
> didn't see any issues.
>
> Thanks,
> Dmitry
>
>> On 23 Feb 2019, at 23:43, Philip Race <philip.race@oracle.com
>> <mailto:philip.race@oracle.com>> wrote:
>>
>> This doesn't regress anything with the OGL pipeline on Linux, does it ?
>>
>> -phil.
>>
>> On 2/18/19, 12:23 AM, Dmitry Markov wrote:
>>> Thank you, Sergey!
>>> Looking for the second +1 from someone else.
>>>
>>> Dmitry
>>>
>>>> On 16 Feb 2019, at 02:10, Sergey Bylokhov
>>>> <Sergey.Bylokhov@oracle.com <mailto:Sergey.Bylokhov@oracle.com>> wrote:
>>>>
>>>> Looks fine.
>>>>
>>>> On 15/02/2019 04:06, Dmitry Markov wrote:
>>>>> Hi Sergey,
>>>>> I think we can just replace ColorModel based calculation of the
>>>>> pixel value with SurfaceData.pixelFor(). The usage of ColorModel
>>>>> is intended for old Solaris platforms which are not supported any
>>>>> more. Please find the new version
>>>>> here:http://cr.openjdk.java.net/~dmarkov/8214109/webrev.01/
>>>>> <http://cr.openjdk.java.net/%7Edmarkov/8214109/webrev.01/>
>>>>> Also I ran all regression tests and didn't observe any new failures.
>>>>> Thanks,
>>>>> Dmitry
>>>>>> On 31 Jan 2019, at 22:25, Sergey Bylokhov
>>>>>> <sergey.bylokhov@oracle.com
>>>>>> <mailto:sergey.bylokhov@oracle.com><mailto:sergey.bylokhov@oracle.com>>
>>>>>> wrote:
>>>>>>
>>>>>> Hi, Dmitry.
>>>>>> On 30/01/2019 05:02, Dmitry Markov wrote:
>>>>>>
>>>>>>> I understand your intention to get rid of "the check of the
>>>>>>> current 2d pipeline" but it appears impossible to move the
>>>>>>> related code to java2d in particular OGL.
>>>>>>
>>>>>> But it will be good to move it to java2d code, since this is ogl
>>>>>> and solaris specific.(if this is really solaris specific then it
>>>>>> looks like a bug in OGL pipeline)
>>>>>>
>>>>>>> Currently OGL uses ArgbPre pixel converter for rendering.
>>>>>>> Default pixel converter is used for calculation of pixel value
>>>>>>> when background colour is set because ArgbPre does not return
>>>>>>> the correct value for OGL on Solaris (according to JDK-6304250).
>>>>>>> I do not see any way to distinguish between setting of
>>>>>>> background colour and other rendering operations from java2d code.
>>>>>>
>>>>>> It is unclear why it is not possible to get this color since the
>>>>>> current fix has a code to calculate this color.
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best regards, Sergey.
>>>>
>>>>
>>>> --
>>>> Best regards, Sergey.
>>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Ok. Approved<br>
<br>
-phil.<br>
<br>
On 2/25/19, 1:42 AM, Dmitry Markov wrote:
<blockquote
cite="mid:580241F8-2CAA-4CBC-946D-CCC5142A000E@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
That's right. I ran corresponding regression tests on Ubuntu and I
didn't see any issues.
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Dmitry<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 23 Feb 2019, at 23:43, Philip Race <<a
moz-do-not-send="true"
href="mailto:philip.race@oracle.com" class="">philip.race@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class=""> This
doesn't regress anything with the OGL pipeline on Linux,
does it ?<br class="">
<br class="">
-phil.<br class="">
<br class="">
On 2/18/19, 12:23 AM, Dmitry Markov wrote:
<blockquote
cite="mid:E7D61689-E37D-4B9E-842E-D1AC192BC7B3@oracle.com"
type="cite" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8" class="">
Thank you, Sergey!
<div class="">Looking for the second +1 from someone
else.</div>
<div class=""><br class="">
</div>
<div class="">Dmitry<br class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On 16 Feb 2019, at 02:10, Sergey
Bylokhov <<a moz-do-not-send="true"
href="mailto:Sergey.Bylokhov@oracle.com"
class="">Sergey.Bylokhov@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="caret-color: rgb(0,
0, 0); font-family: Helvetica; font-size:
12px; font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display:
inline !important;" class="">Looks fine.</span><br
style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display:
inline !important;" class="">On 15/02/2019
04:06, Dmitry Markov wrote:</span><br
style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<blockquote type="cite" style="font-family:
Helvetica; font-size: 12px; font-style:
normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal;
orphans: auto; text-align: start;
text-indent: 0px; text-transform: none;
white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">Hi Sergey,<br
class="">
I think we can just replace ColorModel based
calculation of the pixel value
with SurfaceData.pixelFor(). The usage of
ColorModel is intended for old Solaris
platforms which are not supported any more.
Please find the new version here:<span
class="Apple-converted-space"> </span><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Edmarkov/8214109/webrev.01/"
class="">http://cr.openjdk.java.net/~dmarkov/8214109/webrev.01/</a><br
class="">
Also I ran all regression tests and didn't
observe any new failures.<br class="">
Thanks,<br class="">
Dmitry<br class="">
<blockquote type="cite" class="">On 31 Jan
2019, at 22:25, Sergey Bylokhov <<a
moz-do-not-send="true"
href="mailto:sergey.bylokhov@oracle.com"
class="">sergey.bylokhov@oracle.com</a><span
class="Apple-converted-space"> </span><<a
moz-do-not-send="true"
href="mailto:sergey.bylokhov@oracle.com"
class="">mailto:sergey.bylokhov@oracle.com</a>>>
wrote:<br class="">
<br class="">
Hi, Dmitry.<br class="">
On 30/01/2019 05:02, Dmitry Markov wrote:<br
class="">
<br class="">
<blockquote type="cite" class="">I
understand your intention to get rid of
"the check of the current 2d pipeline"
but it appears impossible to move the
related code to java2d in particular
OGL.<br class="">
</blockquote>
<br class="">
But it will be good to move it to java2d
code, since this is ogl and solaris
specific.(if this is really solaris
specific then it looks like a bug in OGL
pipeline)<br class="">
<br class="">
<blockquote type="cite" class="">Currently
OGL uses ArgbPre pixel converter for
rendering. Default pixel converter is
used for calculation of pixel value when
background colour is set because ArgbPre
does not return the correct value for
OGL on Solaris (according to
JDK-6304250).<br class="">
I do not see any way to distinguish
between setting of background colour and
other rendering operations from java2d
code.<br class="">
</blockquote>
<br class="">
It is unclear why it is not possible to
get this color since the current fix has a
code to calculate this color.<br class="">
<br class="">
<br class="">
--<span class="Apple-converted-space"> </span><br
class="">
Best regards, Sergey.<br class="">
</blockquote>
</blockquote>
<br style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display:
inline !important;" class="">--<span
class="Apple-converted-space"> </span></span><br
style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing:
normal; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal;
word-spacing: 0px;
-webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display:
inline !important;" class="">Best regards,
Sergey.</span></div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic