[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> [12] Review Request: JDK-8215364: JavaFX crashes on Ubuntu 18.04 with Wayland while us
From:       Kevin Rushforth <kevin.rushforth () oracle ! com>
Date:       2018-12-20 19:33:12
Message-ID: a09ad722-2f66-110c-ec3b-51f21fecf39e () oracle ! com
[Download RAW message or body]

+1

-- Kevin


On 12/20/2018 11:03 AM, Phil Race wrote:
> +1
>
> -phil.
>
> On 12/14/18 5:48 AM, Pankaj Bansal wrote:
>>
>> Hi All, Please review fix for the below bug jdk12:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8215364
>>
>> Webrev: http://cr.openjdk.java.net/~pbansal/8215364/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Epbansal/8215364/webrev.00/>
>>
>> Issue:
>>
>> JavaFX uses both X11 and gtk code and gtk3 uses Wayland backend while 
>> running Ubuntu 18.04 in Wayland mode. This results in crash in 
>> JavaFX. This crash is being done under [1] by setting the gtk3 
>> backend to x11 on all systems by setting GDK_BACKEND=x11. This fixes 
>> the JavaFX crash.
>>
>> However, while using the a JFXPanel inside Swing components in 
>> Swing-FX interop with GTKLookAndFeel set as L&F for Swing, the AWT 
>> loads the gtk3 first and as the GDK_BACKEND=x11 is not yet set even 
>> after the fix for [1], the gtk3 starts using the Wayland backend. 
>> Then while initializing the JFXPanel, JavaFX uses the same gtk 
>> library loaded by AWT and this results in crash.
>>
>> Fix:
>>
>> The fix is to set the gtk backend to x11 in AWT as well by setting 
>> the GDK_BACKEND=x11. This fixes the Swing-FX interop crash as well.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8210411
>>
>> Regards,
>> Pankaj Bansal
>>
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html;
      charset=windows-1252">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    +1<br>
    <br>
    -- Kevin<br>
    <br>
    <br>
    <div class="moz-cite-prefix">On 12/20/2018 11:03 AM, Phil Race
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:ed0bf33c-bf73-c500-f933-adf6379ecd45@oracle.com">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      +1<br>
      <br>
      -phil.<br>
      <br>
      <div class="moz-cite-prefix">On 12/14/18 5:48 AM, Pankaj Bansal
        wrote:<br>
      </div>
      <blockquote type="cite"
        cite="mid:546e70ac-eff8-4d58-802a-25d8f04914a6@default">
        <meta http-equiv="Content-Type" content="text/html;
          charset=windows-1252">
        <meta name="Generator" content="Microsoft Word 15 (filtered
          medium)">
        <style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri","sans-serif";
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
        <div class="WordSection1">
          <p class="MsoNormal">Hi All, Please review fix for the below
            bug jdk12:<o:p></o:p></p>
          <p class="MsoNormal"><o:p> </o:p></p>
          <p class="MsoNormal">Bug: <a
              href="https://bugs.openjdk.java.net/browse/JDK-8215364"
              moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8215364</a><o:p></o:p></p>
  <p class="MsoNormal">Webrev: <a
              href="http://cr.openjdk.java.net/%7Epbansal/8215364/webrev.00/"
              moz-do-not-send="true">http://cr.openjdk.java.net/~pbansal/8215364/webrev.00/</a><o:p></o:p></p>
  <p class="MsoNormal"><o:p> </o:p></p>
          <p class="MsoNormal">Issue:<o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:10.5pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:#333333;background:white">JavaFX
  uses both X11 and gtk code and gtk3 uses Wayland backend
              while running Ubuntu 18.04 in Wayland mode. This results
              in crash in JavaFX. This crash is being done under [1] by
              setting the gtk3 backend to x11 on all systems by setting
              GDK_BACKEND=x11. This fixes the JavaFX crash. <o:p></o:p></span></p>
          <p class="MsoNormal"><span
style="font-size:10.5pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:#333333">However,
  while using the a JFXPanel inside Swing components in
              Swing-FX interop with GTKLookAndFeel set as L&amp;F for
              Swing, the AWT loads the gtk3 first and as the
              GDK_BACKEND=x11 is not yet set even after the fix for [1],
              the gtk3 starts using the Wayland backend. Then while
              initializing the JFXPanel, JavaFX uses the same gtk
              library loaded by AWT and this results in crash.<o:p></o:p></span></p>
          <p class="MsoNormal"><span
style="font-size:10.5pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:#333333;background:white"><o:p> \
</o:p></span></p>  <p class="MsoNormal"><span
style="font-size:10.5pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:#333333;background:white">Fix:<o:p></o:p></span></p>
  <p class="MsoNormal"><span
style="font-size:10.5pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:#333333;background:white">The
  fix is to set the gtk backend to x11 in AWT as well by
              setting the GDK_BACKEND=x11. This fixes the Swing-FX
              interop crash as well.<o:p></o:p></span></p>
          <p class="MsoNormal"><o:p> </o:p></p>
          <p class="MsoNormal">[1] <span
style="font-size:10.5pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:#333333;background:white"><a
  href="https://bugs.openjdk.java.net/browse/JDK-8210411"
                moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8210411</a><o:p></o:p></span></p>
  <p class="MsoNormal"><o:p> </o:p></p>
          <p class="MsoNormal">Regards,<br>
            Pankaj Bansal<o:p></o:p></p>
          <p class="MsoNormal"><o:p> </o:p></p>
        </div>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic