[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> RFR: 8211267: StackOverflowError happened by TextField.setFont(...) & Add non interact
From:       Phil Race <philip.race () oracle ! com>
Date:       2018-12-12 17:04:28
Message-ID: a15e30d5-4d8a-00f0-a1a5-e441f41262cb () oracle ! com
[Download RAW message or body]

That looks better.

-phil.

On 12/12/18 12:59 AM, Ichiroh Takiguchi wrote:
> Hello.
>
> I'm very sorry.
> I forgot to put @test tag into FontChangeTest.java testcase.
> (Thanks, Phil)
>
> Could you review the fix again ?
>
> Bug:=C2=A0=C2=A0=C2=A0 https://bugs.openjdk.java.net/browse/JDK-8211267
> Change: https://cr.openjdk.java.net/~itakiguchi/8211267/webrev.03/
>
> Thanks,
> Ichiroh Takiguchi
>
> On 2018-12-05 09:15, Sergey Bylokhov wrote:
>> Looks fine.
>>
>> On 03/12/2018 00:22, Ichiroh Takiguchi wrote:
>>> Hello.
>>>
>>> Thanks, Sergey.
>>> I created new test case for JDK-8214298.
>>>
>>> I merged JDK-8211267 & JDK-8214298.
>>> I removed interactive test case and added JDK-8214298's code.
>>>
>>> Could you review the fix ?
>>>
>>> Bug:=C2=A0=C2=A0=C2=A0 https://bugs.openjdk.java.net/browse/JDK-82112=
67
>>> Change: https://cr.openjdk.java.net/~itakiguchi/8211267/webrev.02/
>>>
>>> Thanks,
>>> Ichiroh Takiguchi
>>>
>>> On 2018-12-01 09:35, Sergey Bylokhov wrote:
>>>> Hello,
>>>>
>>>> I think that you can use invokeAndWait instead of invokeLater(),
>>>> which will wait while the code is executed on EDT, and I am not
>>>> sure that you need to interrupt the main thread of the test.
>>>>
>>>> On 26/11/2018 09:19, Ichiroh Takiguchi wrote:
>>>>> Hello.
>>>>> Could you review the fix ?
>>>>>
>>>>> Issue:
>>>>> JDK-8211267 requires non interactive test case
>>>>>
>>>>> Bug:=C2=A0=C2=A0=C2=A0 https://bugs.openjdk.java.net/browse/JDK-821=
4298
>>>>> Change: https://cr.openjdk.java.net/~itakiguchi/8214298/webrev.00/
>>>>>
>>>>> I'd like to obtain a sponsor for this issue.
>>>>>
>>>>> Thanks,
>>>>> Ichiroh Takiguchi
>>>>> IBM Japan, Ltd.
>>>>>
>>>
>

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic