[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-awt-dev
Subject: <AWT Dev> <AWT dev>[12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac
From: Manajit Halder <manajit.halder () oracle ! com>
Date: 2018-09-21 11:49:05
Message-ID: 65743c3f-8f90-f167-cd56-97af8d3b5c53 () oracle ! com
[Download RAW message or body]
Hi All,
Please review the fix for JDK12.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8209123
<https://bugs.openjdk.java.net/browse/JDK-8206392>
Webrev:
http://cr.openjdk.java.net/~mhalder/8209123/webrev.00/
<http://cr.openjdk.java.net/%7Emhalder/8209123/webrev.00/>
Fix:
Resizibility of Frame with state MAXIMIZED_BOTH is set to false
when Frame is resized and when Frame state is set. Resizibility of Frame
in other states (NORMAL and ICONIFIED) is changed if the previous state
of the frame was MAXIMIZED_BOTH otherwise it is not changed.
Changes in method setResizable()
1) if setResizable passed true, then check if frame is in
MAXIMIZED_BOTH state, if so then set setResizable to false, otherwise
set to true.
2) if setResizable passed false, then set false without checking the
frame MAXIMIZED_BOTH state.
Changes done in method setVisible and setWindowState where Frame state
is set:
1) Before setting any state check if resizibility was changed to
MAXIMIZED_BOTH earlier, if so then set resizibility to false.
2) When Frame state is set to MAXIMIZED_BOTH then set resizibility to
false.
JCK and Jtreg (open and close) tests executed with the change:
1) All automated AWT and Swing tests.
2) All manual AWT and Swing tests related to Frame, Window, JFrame and
JWindow.
Regards,
Manajit
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi All,<br>
<br>
Please review the fix for JDK12.<br>
<br>
<span style="font-family:"MS Gothic"">
</span>Bug: <br>
<a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8209123">https://bugs.openjdk.java.net/browse/JDK-8209123</a></p>
<p><a href="https://bugs.openjdk.java.net/browse/JDK-8206392"> </a><span
style="font-family:"MS Gothic"">
</span>Webrev: <span
style="font-family:"MS Gothic"">
</span><br>
<a
href="http://cr.openjdk.java.net/%7Emhalder/8209123/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~mhalder/8209123/webrev.00/</a></p>
<p>Fix: <span style="font-family:"MS Gothic"">
</span><br>
Resizibility of Frame with state MAXIMIZED_BOTH is set to
false when Frame is resized and when Frame state is set.
Resizibility of Frame in other states (NORMAL and ICONIFIED) is
changed if the previous state of the frame was MAXIMIZED_BOTH
otherwise it is not changed. <br>
</p>
<p>Changes in method setResizable()<br>
1) if setResizable passed true, then check if frame is in
MAXIMIZED_BOTH state, if so then set setResizable to false,
otherwise set to true.<br>
2) if setResizable passed false, then set false without checking
the frame MAXIMIZED_BOTH state.<br>
<br>
Changes done in method setVisible and setWindowState where Frame
state is set:<br>
1) Before setting any state check if resizibility was changed to
MAXIMIZED_BOTH earlier, if so then set resizibility to false.<br>
2) When Frame state is set to MAXIMIZED_BOTH then set
resizibility to false.</p>
<p>JCK and Jtreg (open and close) tests executed with the change:<br>
1) All automated AWT and Swing tests.<br>
2) All manual AWT and Swing tests related to Frame, Window,
JFrame and JWindow. <br>
<br>
</p>
<p>Regards, <span style="font-family:"MS Gothic"">
</span><br>
Manajit</p>
<br>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic