[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-awt-dev
Subject: Re: <AWT Dev> [12] Review Request: 8210692 The "com.sun.awt.SecurityWarning" class can be dropped
From: mandy chung <mandy.chung () oracle ! com>
Date: 2018-09-17 15:31:47
Message-ID: 933c7bc3-5ba3-bb63-2df8-20de1a877115 () oracle ! com
[Download RAW message or body]
On 9/16/18 12:48 AM, Alan Bateman wrote:
> On 15/09/2018 22:00, Philip Race wrote:
>> It was exported in the past .. and it was publicly documented ..
>>
>> http://www.oracle.com/technetwork/articles/javase/appletwarning-135102.html
>>
>>
>> .. so I think Sergey was correct in his "JDK" scope.
>> Implementation would be for something entirely internal.
> I think Sergey's changes are okay.
>
> The main issue with com.sun.awt API is that it tried to be both an
> exported and internal/unsupported API at the same time (it's javadoc
> reads "This class is an implementation detail and only meant for
> limited use outside of the core platform"). This doesn't work for
> modules. In addition the design principles in JEP 200 make it clear
> that standard modules should not export a non-standard package to all
> modules. If there has been extensive use of this API then I could
> imagine it being refactored and moved into a JDK-specific module but
> there was little evidence of usage. So where we ended up in JDK 9 is
> that the API is not exported. This means, as Mandy hinted, you can't
> compile against this API (at least not without --add-exports to the
> compiler). Existing code using this API will continue to run on JDK 9,
> 10, 11 or until the java.desktop module is fully encapsulated or the
> SecurityWarning class is removed. Sergey got there first.
>
Yes. Since it was decided not to export com.sun.awt API (JDK-8051640),
they are no longer supported. Is there a CSR filed officially declaring
com.sun.awt APIs are no longer supported? Since it's already deprecated
for removal, it may be worth to have a release note for JDK-8205588 if
we didn't officially declare it unsupported.
Mandy
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 9/16/18 12:48 AM, Alan Bateman
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:6cea33e2-db84-46df-10f2-d9d3d570062f@oracle.com">On
15/09/2018 22:00, Philip Race wrote:
<br>
<blockquote type="cite">It was exported in the past .. and it was
publicly documented ..
<br>
<br>
<a class="moz-txt-link-freetext" \
href="http://www.oracle.com/technetwork/articles/javase/appletwarning-135102.html">http://www.oracle.com/technetwork/articles/javase/appletwarning-135102.html</a>
<br>
<br>
.. so I think Sergey was correct in his "JDK" scope.
<br>
Implementation would be for something entirely internal.
<br>
</blockquote>
I think Sergey's changes are okay.
<br>
<br>
The main issue with com.sun.awt API is that it tried to be both an
exported and internal/unsupported API at the same time (it's
javadoc reads "This class is an implementation detail and only
meant for limited use outside of the core platform"). This doesn't
work for modules. In addition the design principles in JEP 200
make it clear that standard modules should not export a
non-standard package to all modules. If there has been extensive
use of this API then I could imagine it being refactored and moved
into a JDK-specific module but there was little evidence of usage.
So where we ended up in JDK 9 is that the API is not exported.
This means, as Mandy hinted, you can't compile against this API
(at least not without --add-exports to the compiler). Existing
code using this API will continue to run on JDK 9, 10, 11 or until
the java.desktop module is fully encapsulated or the
SecurityWarning class is removed. Sergey got there first.
<br>
<br>
</blockquote>
<br>
Yes. Since it was decided not to export com.sun.awt API
(JDK-8051640), they are no longer supported. Is there a CSR filed
officially declaring com.sun.awt APIs are no longer supported?
Since it's already deprecated for removal, it may be worth to have a
release note for JDK-8205588 if we didn't officially declare it
unsupported.<br>
<br>
Mandy<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic