[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> [11] Review Request: 8205153 Delete "standard instructions" machinery in the open auto
From:       Phil Race <philip.race () oracle ! com>
Date:       2018-06-22 21:57:25
Message-ID: f770347c-d71e-ee01-c6d5-3e604321ac03 () oracle ! com
[Download RAW message or body]

OK. +1

-phil.

On 06/22/2018 02:49 PM, Sergey Bylokhov wrote:
> I have checked all these tests, there are no any new failures caused 
> by this change.
>
> On 22/06/2018 14:10, Phil Race wrote:
>> I just want to know that all these updated tests still pass ?
>>
>> -phil.
>>
>> On 06/22/2018 02:08 PM, Sergey Bylokhov wrote:
>>> On 22/06/2018 13:56, Phil Race wrote:
>>>> I dozed off trying to review this a couple of days ago ;-)
>>>> I really just want to know if the tests all pass after the update ?
>>>
>>> Only the tests which previously sometimes fail because of 
>>> instructions windows which were open on top of the test window. I 
>>> did not change any other logic in the tests, other than mechanical 
>>> removing of part of the code just to simplify webrev. The next step 
>>> will be drop of applet usage(also w/o altered the logic of the tests).
>>>
>>>>
>>>> -phil.
>>>>
>>>>
>>>> On 06/22/2018 01:49 PM, Sergey Bylokhov wrote:
>>>>> Any volunteers for review?
>>>>> =)
>>>>>
>>>>> On 18/06/2018 12:09, Sergey Bylokhov wrote:
>>>>>> Hello.
>>>>>> Please review the fix for jdk11.
>>>>>>
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8205153
>>>>>> Webrev: http://cr.openjdk.java.net/~serb/8205153/webrev.00
>>>>>>
>>>>>> This fix is a part of the effort to cleanup and stabilize our 
>>>>>> tests. This change will delete "standard instructions" machinery 
>>>>>> in the open automated tests, which is just a copy-pasted code to 
>>>>>> to show this message to the user:
>>>>>> "This is an AUTOMATIC test, simply wait until it is done."
>>>>>>
>>>>>> In most cases it doubles the amount of code in the test, and make 
>>>>>> it difficult to update such tests. Also not all tests assume that 
>>>>>> the instruction frame could be opened on top of the test frame, 
>>>>>> which make the test unstable.
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]