[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> RFR: 4475138 getBestCursorSize and XFree86 4.1.0
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2018-06-22 8:30:42
Message-ID: 1e131f00-0ea6-0268-2e94-9f1e28e83b38 () oracle ! com
[Download RAW message or body]

Looks fine.

On 21/06/2018 09:57, Ichiroh Takiguchi wrote:
> Thanks Sergey.
> 
> Hello.
> Could you review it ?
> 
> Bug:       https://bugs.openjdk.java.net/browse/JDK-4475138
> Change: http://cr.openjdk.java.net/~aleonard/4475138/webrev.00/
> 
> Thanks,
> Ichiroh Takiguchi
> IBM Japan, Ltd.
> 
> On 2018-06-21 11:42, Sergey Bylokhov wrote:
> > Looks like the bug is known:
> > https://bugs.openjdk.java.net/browse/JDK-4475138
> > Please send a review request using this bugid.
> > 
> > On 19/06/2018 06:55, Ichiroh Takiguchi wrote:
> > > Hello,
> > > IBM would like to contribute a patch to OpenJDK project.
> > > 
> > > DnD cursor is too big on IBM AIX. Although XQueryBestCursor() returns 
> > > 64x64 dots in the environment,
> > > 32x32 dots are preferred.
> > > 
> > > I'd like to obtain a sponsor for this patch.
> > > --------
> > > --- old/src/java.desktop/unix/classes/sun/awt/X11/XCustomCursor.java 
> > > 2018-06-19 22:44:32 +0000
> > > +++ new/src/java.desktop/unix/classes/sun/awt/X11/XCustomCursor.java 
> > > 2018-06-19 22:44:32 +0000
> > > @@ -63,6 +63,10 @@
> > > 
> > > XlibWrapper.XQueryBestCursor(display,root_window, 
> > > Math.abs(preferredWidth),Math.abs(preferredHeight),XlibWrapper.larg1,XlibWrapper.larg2); \
> > >  d = new 
> > > Dimension(XlibWrapper.unsafe.getInt(XlibWrapper.larg1),XlibWrapper.unsafe.getInt(XlibWrapper.larg2)); \
> > >  +                       if ( preferredWidth > 0   && preferredHeight > 0 ) {
> > > +                               d.width = Math.min(d.width, preferredWidth);
> > > +                               d.height = Math.min(d.height, preferredHeight);
> > > +                       }
> > > }
> > > finally {
> > > XToolkit.awtUnlock();
> > > --------
> > > 
> > > Thanks,
> > > Ichiroh Takiguchi
> > > IBM Japan, Ltd.
> > > 
> 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]