[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> [10] Review Request: 8193012 Small cleanup of AWTEvent class
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2017-12-05 18:26:01
Message-ID: 6846ae69-4d97-ffcc-ee95-3a7ecebda394 () oracle ! com
[Download RAW message or body]

On 05/12/2017 08:56, Semyon Sadetsky wrote:
> Since this is a code cleanup can you remove all redundant initializers 
> in the class as well. Also the volatile modifier for the acc field can 
> be replaced by final.

This is a code cleanup after the one fix, which did not clean after itself.

> 
> --Semyon
> 
> On 12/04/2017 01:59 PM, Sergey Bylokhov wrote:
>>
>> Hello.
>> Please review small cleanup for jdk10.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8193012
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/8193012/webrev.00
>>
>> The fix for JDK-8129854[1] missed some fields in AWTEvent class which 
>> became unused.
>>
>> [1] http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/dc69f25a52aa#l9.1
>>
> 


-- 
Best regards, Sergey.
[prev in list] [next in list] [prev in thread] [next in thread]