[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> [10] RFR JDK-8190456: sanity/client/SwingSet/src/ComboBoxDemoTest.java failed with NPE
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2017-11-08 13:57:19
Message-ID: 591f2766-de4b-ef6a-e3f5-24c1244a1783 () oracle ! com
[Download RAW message or body]

+1

On 07/11/2017 23:52, Prasanta Sadhukhan wrote:
> +1
> 
> Regards
> Prasanta
> On 11/8/2017 11:58 AM, Muneer Kolarkunnu wrote:
>>
>> Hi Prasanta,
>>
>> I corrected it and please find the updated webrev: 
>> http://cr.openjdk.java.net/~akolarkunnu/8190456/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Eakolarkunnu/8190456/webrev.01/>
>>
>> I tested fix with client sanity tests for 1000 iterations on SBR and 
>> passed all tests without any new issues.
>>
>> Regards,
>>
>> Muneer
>>
>> *From:*Prasanta Sadhukhan
>> *Sent:* Friday, November 03, 2017 11:49 AM
>> *To:* Muneer Kolarkunnu; awt-dev@openjdk.java.net
>> *Subject:* Re: <AWT Dev> [10] RFR JDK-8190456: 
>> sanity/client/SwingSet/src/ComboBoxDemoTest.java failed with NPE from 
>> java.awt.EventQueue.getCurrentEventImpl()
>>
>> Hi Muneer,
>>
>> Earlier, before your fix, if Thread.currentThread() is not equal to 
>> dispatchThread, then it was returning " null", but now it will not 
>> return anything even though return value should be AWTEvent.
>> Is it not giving any compilation problem?
>>
>> Regards
>> Prasanta
>>
>> On 11/1/2017 2:03 PM, Muneer Kolarkunnu wrote:
>>
>>     Hi All,
>>
>>     Please review fix for the below bug:
>>
>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8190456
>>
>>     Webrev: http://cr.openjdk.java.net/~akolarkunnu/8190456/webrev.00/
>>     <http://cr.openjdk.java.net/%7Eakolarkunnu/8190456/webrev.00/>
>>
>>     This issue observed during SBR(Same Binary Run) execution of
>>     client sanity tests. Same exception observed from test case
>>     sanity/client/SwingSet/src/DialogDemoTest.java also.
>>     It is a random failure, observed 2 times in 1000 iterations.
>>
>>     In ComboBoxDemoTest, it is happening while changing the selection
>>     on a combo box.
>>
>>     In DialogDemoTest, it is happening during button press.
>>
>>     Fix: As currentEvent is a WeakReference, added null check for
>>     dispatchThread use case also, similar to
>>     fxAppThreadIsDispatchThread use case.
>>
>>     Regards,
>>
>>     Muneer
>>
> 


-- 
Best regards, Sergey.
[prev in list] [next in list] [prev in thread] [next in thread]