[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> Review request for 8153184: BorderLayout javadoc says current version of JDK is 1.2
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2016-05-25 10:40:14
Message-ID: 5ab0f2e3-d116-a737-6b2e-5464cf0afae6 () oracle ! com
[Download RAW message or body]

+1

On 24.05.16 14:04, prasanta sadhukhan wrote:
> +1.
> 
> Regards
> Prasanta
> On 5/24/2016 4:20 PM, Muneer Kolarkunnu wrote:
> > 
> > New webrev link : http://cr.openjdk.java.net/~jcm/8153184/webrev.01/
> > <http://cr.openjdk.java.net/%7Ejcm/8153184/webrev.01/>
> > 
> > 
> > 
> > Regards,
> > 
> > Muneer
> > 
> > 
> > 
> > *From:*Muneer Kolarkunnu
> > *Sent:* Tuesday, May 24, 2016 4:12 PM
> > *To:* Prasanta Sadhukhan; awt-dev@openjdk.java.net
> > *Subject:* Re: <AWT Dev> Review request for 8153184: BorderLayout
> > javadoc says current version of JDK is 1.2
> > 
> > 
> > 
> > Hi Prasanta,
> > 
> > 
> > 
> > I raised ccc and it got approved:http://ccc.us.oracle.com/8153184
> > 
> > 
> > 
> > Added the label "noreg-doc" to bug report and removed the test case[It
> > got added by mistake].
> > 
> > 
> > 
> > Regards,
> > 
> > Muneer
> > 
> > 
> > 
> > *From:*prasanta sadhukhan
> > *Sent:* Tuesday, May 17, 2016 12:24 PM
> > *To:* Muneer Kolarkunnu; awt-dev@openjdk.java.net
> > <mailto:awt-dev@openjdk.java.net>
> > *Subject:* Re: <AWT Dev> Review request for 8153184: BorderLayout
> > javadoc says current version of JDK is 1.2
> > 
> > 
> > 
> > Looks good to me. But the testcase has no bearing to this bug and
> > should be removed and "noreg-doc" label needs to be added to bugreport.
> > Also, a ccc needs to be raised for this.
> > 
> > Regards
> > Prasanta
> > 
> > *From:*Muneer Kolarkunnu
> > *Sent:* Thursday, May 12, 2016 5:19 PM
> > *To:* awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>
> > *Subject:* <AWT Dev> Review request for 8153184: BorderLayout javadoc
> > says current version of JDK is 1.2
> > 
> > 
> > 
> > Hi All,
> > 
> > Please review the fix for bug 8153184,
> > 
> > Webrev:
> > http://cr.openjdk.java.net/~jcm/8153184/webrev.00/
> > <http://cr.openjdk.java.net/%7Ejcm/8153184/webrev.00/>
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8153184
> > 
> > 
> > 
> > Issue:
> > 
> > It is a documentation bug, it is mentioning version information in the
> > javadoc, ie;”[Currently (in the Java 2 platform v1.2)]” . So it is
> > difficult to maintain this kind of version information in the javadoc,
> > just removing that version information.
> > 
> > Links to faulty
> > javadoc:<http://download.java.net/java/jdk9/docs/api/java/awt/BorderLayout.html>http://download.java.net/java/jdk9/docs/api/java/awt/BorderLayout.html
> >  
> > 
> > <https://docs.oracle.com/javase/8/docs/api/java/awt/BorderLayout.html>https://docs.oracle.com/javase/8/docs/api/java/awt/BorderLayout.html
> >  
> > 
> > 
> > Fix:
> > 
> > Removed the version information from javadoc as it is
> > difficult to maintain in different versions
> > 
> > 
> > 
> > Regards,
> > 
> > Muneer
> > 
> > 
> > 
> > 
> > 
> 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]