[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-awt-dev
Subject: Re: <AWT Dev> Review Request for 7035459: [TEST_BUG] java/awt/Focus/TranserFocusToWindow/TranserFocu
From: Ambarish Rapte <ambarish.rapte () oracle ! com>
Date: 2016-01-04 7:25:24
Message-ID: 2a3a05f2-b29a-497f-94d2-c0ffc68f3a4d () default
[Download RAW message or body]
Hi Prem,
The test fails on mac, Please check.
Thanks,
Ambarish
From: Prem Balakrishnan
Sent: Monday, December 28, 2015 11:28 AM
To: Semyon Sadetsky; Ambarish Rapte; HYPERLINK \
"mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net
Subject: Review Request for 7035459: [TEST_BUG] \
java/awt/Focus/TranserFocusToWindow/TranserFocusToWindow.java failed
Hi,
Please review fix for JDK9,
Bug: https://bugs.openjdk.java.net/browse/JDK-7035459
Webrev: http://cr.openjdk.java.net/~arapte/prem/7035459/webrev.00/
Issue:
Exception java.lang.RuntimeException: can not set focus on \
java.awt.Button[button0,0,0,115x23,label=button for focus]
Cause:
Initial Robot action on clicking title bar of Owner frame was actually minimizing the \
window(also button associated with it).
When trying to focus on the Button associated with this window, Exception was thrown
Fix:
1. Increased window width from 200 to 300. (to ensure click on title bar does \
not click the minimize button).
2. Event listeners were added after performing Robot actions, because of which \
events were not handled properly.
Hence moved the addListeners code before performing Robot action.
Thanks,
Prem
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1477991427;
mso-list-type:hybrid;
mso-list-template-ids:-1497618916 1582727892 67698713 67698715 67698703 67698713 \
67698715 67698703 67698713 67698715;} @list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:.75in;
text-indent:-.25in;}
@list l0:level2
{mso-level-tab-stop:1.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level4
{mso-level-tab-stop:2.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-tab-stop:2.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-tab-stop:3.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level7
{mso-level-tab-stop:3.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-tab-stop:4.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-tab-stop:4.5in;
mso-level-number-position:left;
text-indent:-.25in;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div \
class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Hi \
Prem,<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'> \
The test fails on mac, Please check.<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>Ambarish<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Prem Balakrishnan \
<br><b>Sent:</b> Monday, December 28, 2015 11:28 AM<br><b>To:</b> Semyon Sadetsky; \
Ambarish Rapte; <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br><b>Subject:</b> \
Review Request for 7035459: [TEST_BUG] \
java/awt/Focus/TranserFocusToWindow/TranserFocusToWindow.java \
failed<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal style='text-align:justify'>Hi,<o:p></o:p></p><p class=MsoNormal \
style='text-align:justify;text-indent:.5in'>Please review fix for \
JDK9,<o:p></o:p></p><p class=MsoNormal style='text-align:justify'><span \
style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal \
style='text-align:justify;text-indent:.5in'><b>Bug:</b> <span \
style='color:#1F497D'><a \
href="https://bugs.openjdk.java.net/browse/JDK-7035459">https://bugs.openjdk.java.net/browse/JDK-7035459</a> \
</span><o:p></o:p></p><p class=MsoNormal \
style='text-align:justify;text-indent:.5in'><b>Webrev:</b> <span \
style='color:#1F497D'><a \
href="http://cr.openjdk.java.net/~arapte/prem/7035459/webrev.00/">http://cr.openjdk.java.net/~arapte/prem/7035459/webrev.00/</a></span><o:p></o:p></p><p \
class=MsoNormal style='text-align:justify;text-indent:.5in'><o:p> </o:p></p><p \
class=MsoNormal style='text-align:justify;text-indent:.5in'><o:p> </o:p></p><p \
class=MsoNormal style='text-align:justify;text-indent:.5in'><b>Issue:<span \
style='color:#1F497D'><o:p></o:p></span></b></p><p class=MsoNormal \
style='text-align:justify;text-indent:.5in'>Exception java.lang.RuntimeException: can \
not set focus on java.awt.Button[button0,0,0,115x23,label=button for \
focus]<o:p></o:p></p><p class=MsoNormal \
style='text-align:justify'><o:p> </o:p></p><p class=MsoNormal \
style='text-align:justify;text-indent:.5in'><b>Cause:<o:p></o:p></b></p><p \
class=MsoNormal style='text-align:justify;text-indent:.5in'>Initial Robot action on \
clicking title bar of Owner frame was actually minimizing the window(also button \
associated with it). <o:p></o:p></p><p class=MsoNormal \
style='text-align:justify;text-indent:.5in'>When trying to focus on the Button \
associated with this window, Exception was thrown<o:p></o:p></p><p class=MsoNormal \
style='text-align:justify;text-indent:.5in'><o:p> </o:p></p><p class=MsoNormal \
style='text-align:justify;text-indent:.5in'><b>Fix:<o:p></o:p></b></p><p \
class=MsoListParagraph \
style='margin-left:.75in;text-align:justify;text-indent:-.25in;mso-list:l0 level1 \
lfo2'><![if !supportLists]><span style='mso-list:Ignore'>1.<span style='font:7.0pt \
"Times New Roman"'> \
</span></span><![endif]>Increased window width from 200 to 300. (to ensure click on \
title bar does not click the minimize button).<o:p></o:p></p><p \
class=MsoListParagraph style='margin-left:.75in;text-indent:-.25in;mso-list:l0 level1 \
lfo2;text-autospace:none'><![if !supportLists]><span style='mso-list:Ignore'>2.<span \
style='font:7.0pt "Times New Roman"'> \
</span></span><![endif]>Event listeners were added after performing Robot actions, \
because of which events were not handled properly.<o:p></o:p></p><p class=MsoNormal \
style='margin-left:.5in;text-autospace:none'> \
Hence moved the addListeners code before performing Robot \
action.<o:p></o:p></p><p class=MsoNormal \
style='text-align:justify'><o:p> </o:p></p><p class=MsoNormal \
style='text-align:justify;text-indent:.5in'><o:p> </o:p></p><p class=MsoNormal \
style='text-align:justify'>Thanks,<o:p></o:p></p><p class=MsoNormal \
style='text-align:justify'>Prem<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic