[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-awt-dev
Subject: Re: <AWT Dev> Review request for 8132766: [TESTBUG] Fix JDK-8068228 failed for java/awt/Mouse/Maximi
From: Semyon Sadetsky <semyon.sadetsky () oracle ! com>
Date: 2015-11-30 7:34:55
Message-ID: 565BFC1F.4000905 () oracle ! com
[Download RAW message or body]
Hi Manajit,
the fix looks good.
--Semyon
On 11/30/2015 8:38 AM, Manajit Halder wrote:
> Hi Semyon,
>
> Gentle remainder. Please review the changes.
>
> Thanks,
> Manajit
>
>
>> On 25-Nov-2015, at 5:52 pm, Manajit Halder <manajit.halder@oracle.com
>> <mailto:manajit.halder@oracle.com>> wrote:
>>
>> Hi Semyon,
>>
>> Thank you for the comment. I have changed Logger with
>> System.err.println.
>>
>> Please review the changes in the webrev.01:
>> http://cr.openjdk.java.net/~aniyogi/manajit/8132766/webrev.01/
>> <http://cr.openjdk.java.net/%7Eaniyogi/manajit/8132766/webrev.01/>
>>
>> Regards,
>> Manajit
>>
>>> On 25-Nov-2015, at 1:22 pm, Semyon Sadetsky
>>> <semyon.sadetsky@oracle.com <mailto:semyon.sadetsky@oracle.com>> wrote:
>>>
>>> Hi Manajit,
>>>
>>> Why do you use Logger for output? Potentially Logger can be
>>> configured to redirect or hide output.
>>> Are you sure that it will be jprt compatible?
>>> I afraid that jprt team expects that System.out/err are only used in
>>> tests, so we may miss the Logger output in the test report.
>>>
>>> --Semyon
>>>
>>>
>>> On 11/23/2015 2:38 PM, Manajit Halder wrote:
>>>> Hi All,
>>>>
>>>> Kindly review the fix for JDK9.
>>>> *Bug*:
>>>> https://bugs.openjdk.java.net/browse/JDK-8132766
>>>> <https://bugs.openjdk.java.net/browse/JDK-8019280>
>>>>
>>>> *Webrev*:
>>>> http://cr.openjdk.java.net/~rchamyal/manajit/8132766/webrev.00/
>>>>
>>>> *Issue*: Unable to determine title component. MetalLookAndFeel was
>>>> not getting set.
>>>>
>>>> *Cause*: setDefaultLookAndFeelDecorated(true) was not setting the
>>>> look and feel to MetalLookAndFeel.
>>>>
>>>> *Fix*: Set the look and feel to MetalLookAndFeel using
>>>> setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
>>>> Modified the code as per the comment given in mail
>>>> http://mail.openjdk.java.net/pipermail/awt-dev/2015-August/009858.html
>>>> Reformatted the code to get rid of Applet and made it
>>>> more modular.
>>>>
>>>> Regards,
>>>> Manajit
>>>
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Manajit,<br>
<br>
the fix looks good.<br>
<br>
--Semyon<br>
<br>
<div class="moz-cite-prefix">On 11/30/2015 8:38 AM, Manajit Halder
wrote:<br>
</div>
<blockquote
cite="mid:49722DF6-6776-4D18-89DA-027E458AB39A@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
Hi Semyon,
<div class=""><br class="">
</div>
<div class="">Gentle remainder. Please review the changes.</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Manajit</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 25-Nov-2015, at 5:52 pm, Manajit Halder
<<a moz-do-not-send="true"
href="mailto:manajit.halder@oracle.com" \
class="">manajit.halder@oracle.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space;" class="">Hi
Semyon,
<div class=""><br class="">
</div>
<div class="">Thank you for the comment. I have changed
Logger with System.err.println. </div>
<div class=""><br class="">
</div>
<div class="">Please review the changes in the
webrev.01:</div>
<div class=""><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eaniyogi/manajit/8132766/webrev.01/"
class="">http://cr.openjdk.java.net/~aniyogi/manajit/8132766/webrev.01/</a></div>
<div class=""><br class="">
</div>
<div class="">Regards,</div>
<div class="">Manajit</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On 25-Nov-2015, at 1:22 pm, Semyon
Sadetsky <<a moz-do-not-send="true"
href="mailto:semyon.sadetsky@oracle.com"
class="">semyon.sadetsky@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class="">
Hi Manajit,<br class="">
<br class="">
Why do you use Logger for output? Potentially
Logger can be configured to redirect or hide
output. <br class="">
Are you sure that it will be jprt compatible?
<br class="">
I afraid that jprt team expects that
System.out/err are only used in tests, so we
may miss the Logger output in the test report.<br
class="">
<br class="">
--Semyon<br class="">
<br class="">
<br class="">
<div class="moz-cite-prefix">On 11/23/2015
2:38 PM, Manajit Halder wrote:<br class="">
</div>
<blockquote
cite="mid:5652FA9A.8060505@oracle.com"
type="cite" class="">
<meta http-equiv="content-type"
content="text/html; charset=windows-1252"
class="">
Hi All,
<div class=""><br class="">
</div>
<div class="">Kindly review the fix for
JDK9.</div>
<div class=""><b class="">Bug</b>: </div>
<div class=""><a moz-do-not-send="true"
\
href="https://bugs.openjdk.java.net/browse/JDK-8019280"
\
class="">https://bugs.openjdk.java.net/browse/JDK-8132766</a></div> <div \
class=""><br class=""> </div>
<div class=""><b class="">Webrev</b>: </div>
<div class=""><a moz-do-not-send="true"
class="moz-txt-link-freetext"
\
href="http://cr.openjdk.java.net/%7Erchamyal/manajit/8132766/webrev.00/">http://cr.openjdk.java.net/~rchamyal/manajit/8132766/webrev.00/</a></div>
<div class=""><br class="">
</div>
<div class=""><b class="">Issue</b>: Unable
to determine title component.
MetalLookAndFeel was not getting set.<br
class="">
</div>
<div class=""><br class="">
</div>
<div class=""><b class="">Cause</b>:
setDefaultLookAndFeelDecorated(true) was
not setting the look and feel to
MetalLookAndFeel. <br class="">
<br class="">
</div>
<div class=""><b class="">Fix</b>: Set the
look and feel to MetalLookAndFeel using
\
setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");<br class="">
Modified the code as per the
comment given in mail <a
moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://mail.openjdk.java.net/pipermail/awt-dev/2015-August/009858.html"><a \
class="moz-txt-link-freetext" \
href="http://mail.openjdk.java.net/pipermail/awt-dev/2015-August/009858.html">http://mail.openjdk.java.net/pipermail/awt-dev/2015-August/009858.html</a></a><br
class="">
Reformatted the code to get rid
of Applet and made it more modular.<br
class="">
<br class="">
</div>
<div class="">Regards,<br class="">
Manajit<br class="">
</div>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic