[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    Re: <AWT Dev> [9] Review request for JDK-7011513: GTK FileDialog modality issues
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2015-04-15 19:10:30
Message-ID: 552EB7A6.4090107 () oracle ! com
[Download RAW message or body]

Hi, Alexander.
Do we need a new iteration of the fix, or this one is latest?

On 20.01.14 19:16, Alexander Zvegintsev wrote:
> Hi Sergey,
>
> I've updated the fix:
> http://cr.openjdk.java.net/~azvegint/jdk/9/7011513/webrev.01/
>
> Now it returns location and size of a file dialog correctly.
>
> [1] 
> https://developer.gnome.org/gtk2/stable/GtkWidget.html#GtkWidget-configure-event
> Thanks,
>
> Alexander.
> On 01/10/2014 04:32 PM, Sergey Bylokhov wrote:
>> Hi, Alexander.
>> The fix looks good.
>>
>> On 10.01.2014 15:25, Alexander Zvegintsev wrote:
>>> Hello AWT team,
>>>
>>> Please review the fix
>>> http://cr.openjdk.java.net/~azvegint/jdk/9/7011513/webrev.00/
>>> for
>>> https://bugs.openjdk.java.net/browse/JDK-7011513
>>>
>>> Currently a Gtk file chooser dialog window can be obscured by its 
>>> owner window,
>>> this happens because we do not specify a parent window for obvious 
>>> reason: our owner window in not an instance of GtkWindow.
>>> However it can be workarounded by setting up a WM_TRANSIENT_FOR 
>>> property [1][2].
>>>
>>> I tested this on Solaris 10/11, OEL 6, Ubuntu 13.04, all works fine 
>>> for me.
>>>
>>> [1] http://tronche.com/gui/x/icccm/sec-4.html#WM_TRANSIENT_FOR
>>> [2] 
>>> http://tronche.com/gui/x/xlib/ICC/client-to-window-manager/XSetTransientForHint.html
>>> [3] 
>>> https://developer.gnome.org/gtk2/stable/GtkWidget.html#gtk-widget-realize
>>> [4] 
>>> https://developer.gnome.org/gdk/stable/gdk-X-Window-System-Interaction.html#gdk-x11-drawable-get-xid
>>>
>>> -- 
>>> Thanks,
>>>
>>> Alexander.
>>
>>
>> -- 
>> Best regards, Sergey.
>


-- 
Best regards, Sergey.


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Hi, Alexander.<br>
      Do we need a new iteration of the fix, or this one is latest?<br>
      <br>
      On 20.01.14 19:16, Alexander Zvegintsev wrote:<br>
    </div>
    <blockquote cite="mid:52DD3DBE.50509@oracle.com" type="cite">
      <meta content="text/html; charset=windows-1252"
        http-equiv="Content-Type">
      <div class="moz-cite-prefix">Hi Sergey,<br>
        <br>
        I've updated the fix:<br>
        <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="http://cr.openjdk.java.net/%7Eazvegint/jdk/9/7011513/webrev.01/">http://cr.openjdk.java.net/~azvegint/jdk/9/7011513/webrev.01/</a><br>
  <br>
        Now it returns location and size of a file dialog correctly.<br>
        <br>
        <meta http-equiv="content-type" content="text/html;
          charset=windows-1252">
        [1]
        <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://developer.gnome.org/gtk2/stable/GtkWidget.html#GtkWidget-configure-event \
">https://developer.gnome.org/gtk2/stable/GtkWidget.html#GtkWidget-configure-event</a><br>
  <pre class="moz-signature" cols="72">Thanks,

Alexander.</pre>
        On 01/10/2014 04:32 PM, Sergey Bylokhov wrote:<br>
      </div>
      <blockquote cite="mid:52CFE840.9050408@oracle.com" type="cite">
        <meta content="text/html; charset=windows-1252"
          http-equiv="Content-Type">
        <div class="moz-cite-prefix">Hi, Alexander.<br>
          The fix looks good.<br>
          <br>
          On 10.01.2014 15:25, Alexander Zvegintsev wrote:<br>
        </div>
        <blockquote cite="mid:52CFD898.7070100@oracle.com" type="cite">
          <meta http-equiv="content-type" content="text/html;
            charset=windows-1252">
          Hello AWT team,<br>
          <br>
          Please review the fix<br>
          <a moz-do-not-send="true" class="moz-txt-link-freetext"
            href="http://cr.openjdk.java.net/%7Eazvegint/jdk/9/7011513/webrev.00/">http://cr.openjdk.java.net/~azvegint/jdk/9/7011513/webrev.00/</a><br>
  for <br>
          <a moz-do-not-send="true" class="moz-txt-link-freetext"
            href="https://bugs.openjdk.java.net/browse/JDK-7011513">https://bugs.openjdk.java.net/browse/JDK-7011513</a><br>
  <br>
          Currently a Gtk file chooser dialog window can be obscured by
          its owner window, <br>
          this happens because we do not specify a parent window for
          obvious reason: our owner window in not an instance of
          GtkWindow.<br>
          However it can be workarounded by setting up a
          WM_TRANSIENT_FOR property [1][2].<br>
          <br>
          I tested this on Solaris 10/11, OEL 6, Ubuntu 13.04, all works
          fine for me.<br>
          <br>
          [1] <a moz-do-not-send="true" class="moz-txt-link-freetext"
            href="http://tronche.com/gui/x/icccm/sec-4.html#WM_TRANSIENT_FOR">http://tronche.com/gui/x/icccm/sec-4.html#WM_TRANSIENT_FOR</a><br>
  <meta http-equiv="content-type" content="text/html;
            charset=windows-1252">
          [2] <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://tronche.com/gui/x/xlib/ICC/client-to-window-manager/XSetTransientForHint. \
html">http://tronche.com/gui/x/xlib/ICC/client-to-window-manager/XSetTransientForHint.html</a><br>
  [3] <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://developer.gnome.org/gtk2/stable/GtkWidget.html#gtk-widget-realize">https://developer.gnome.org/gtk2/stable/GtkWidget.html#gtk-widget-realize</a><br>
  [4] <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://developer.gnome.org/gdk/stable/gdk-X-Window-System-Interaction.html#gdk- \
x11-drawable-get-xid">https://developer.gnome.org/gdk/stable/gdk-X-Window-System-Interaction.html#gdk-x11-drawable-get-xid</a><br>
  <br>
          <pre class="moz-signature" cols="72">-- 
Thanks,

Alexander.</pre>
        </blockquote>
        <br>
        <br>
        <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
      </blockquote>
      <br>
    </blockquote>
    <br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic