[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-awt-dev
Subject: <AWT Dev> Approved: Re: [9] Review request for RFE-8074882: Support 'replacement range' feature in t
From: Alexander Zuev <alexander.zuev () oracle ! com>
Date: 2015-04-12 10:57:31
Message-ID: F8F4260D-F0DC-4F23-9D52-0C9FF49EC590 () oracle ! com
[Download RAW message or body]
Looks fine to me.
/Alex
> On 10 Apr 2015, at 15:12, Anton Nashatyrev <anton.nashatyrev@oracle.com> wrote:
>
> Hello,
>
> any volunteers to review?
>
> Thanks!
> Anton.
>
> > On 01.04.2015 18:43, Anton Nashatyrev wrote:
> > Hello,
> > could you please review the following IM API extension proposal:
> >
> > fix: http://cr.openjdk.java.net/~anashaty/8074882/9/webrev.00/ \
> > <http://cr.openjdk.java.net/%7Eanashaty/8074882/9/webrev.00/>
> > bug: https://bugs.openjdk.java.net/browse/JDK-8074882
> >
> > Problem: Press-and-hold Mac IM (when an accented char variant could be selected) \
> > couldn't be supported by the components other than TextComponent
> > MacOS Cocoa Input Method API supports the 'replacement range' parameter in its \
> > callbacks indicating what range of the committed text of the document should be \
> > replaced with the new composed text. In case of press-and-hold IM this parameter \
> > always indicates the previous char.
> > Fix: extends the IM API to support the 'replacement range'. The fix includes the \
> > new API, its implementation and adoption to the existing JTextComponent, the \
> > changes to be made in the MacOS code to conform the new API. The sample custom \
> > Java IM is attached to the JBS report to demonstrate the new API usage and test \
> > the implementation.
> > Thanks!
> > Anton.
>
[Attachment #3 (text/html)]
<html><head><meta http-equiv="content-type" content="text/html; \
charset=utf-8"></head><body dir="auto"><div>Looks fine to me.<br><br><span \
style="font-size: 13pt;">/Alex</span></div><div><br>On 10 Apr 2015, at 15:12, Anton \
Nashatyrev <<a href="mailto:anton.nashatyrev@oracle.com">anton.nashatyrev@oracle.com</a>> \
wrote:<br><br></div><blockquote \
type="cite"><div><span>Hello,</span><br><span></span><br><span> any \
volunteers to review?</span><br><span></span><br><span>Thanks!</span><br><span>Anton.</span><br><span></span><br><span>On \
01.04.2015 18:43, Anton Nashatyrev wrote:</span><br><blockquote \
type="cite"><span>Hello,</span><br></blockquote><blockquote type="cite"><span> \
could you please review the following IM API extension \
proposal:</span><br></blockquote><blockquote \
type="cite"><span></span><br></blockquote><blockquote type="cite"><span>fix: <a \
href="http://cr.openjdk.java.net/~anashaty/8074882/9/webrev.00/">http://cr.openjdk.java.net/~anashaty/8074882/9/webrev.00/</a> \
<<a href="http://cr.openjdk.java.net/%7Eanashaty/8074882/9/webrev.00/">http://cr.op \
enjdk.java.net/%7Eanashaty/8074882/9/webrev.00/</a>></span><br></blockquote><blockquote \
type="cite"><span>bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8074882">https://bugs.openjdk.java.net/browse/JDK-8074882</a></span><br></blockquote><blockquote \
type="cite"><span></span><br></blockquote><blockquote type="cite"><span> \
Problem: Press-and-hold Mac IM (when an accented char variant could \
be selected) couldn't be supported by the components other than \
TextComponent</span><br></blockquote><blockquote \
type="cite"><span></span><br></blockquote><blockquote type="cite"><span> \
MacOS Cocoa Input Method API supports the 'replacement range' \
parameter in its callbacks indicating what range of the committed text of the \
document should be replaced with the new composed text. In case of press-and-hold IM \
this parameter always indicates the previous char.</span><br></blockquote><blockquote \
type="cite"><span></span><br></blockquote><blockquote type="cite"><span> \
Fix: extends the IM API to support the 'replacement range'. The fix \
includes the new API, its implementation and adoption to the existing JTextComponent, \
the changes to be made in the MacOS code to conform the new \
API.</span><br></blockquote><blockquote type="cite"><span> The \
sample custom Java IM is attached to the JBS report to demonstrate the new API usage \
and test the implementation.</span><br></blockquote><blockquote \
type="cite"><span></span><br></blockquote><blockquote \
type="cite"><span>Thanks!</span><br></blockquote><blockquote \
type="cite"><span>Anton.</span><br></blockquote><span></span><br></div></blockquote></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic